node-chakracore icon indicating copy to clipboard operation
node-chakracore copied to clipboard

Support dotall ('s' flag) in regexp

Open boingoing opened this issue 6 years ago • 3 comments

  • Version: All
  • Platform: All
  • Subsystem: All

ChakraCore does not support the 's' regex flag so if Javascript code in node.js uses this flag, we will throw a syntax error. We can work around this by replacing '.' by something like '[\s\S]' and removing the flag but this is a temporary solution at best. When ChakraCore supports the dotall flag, we should remove any of these workarounds. Including this one: 783e99accd

boingoing avatar Jul 11 '18 00:07 boingoing

ChakraCore is tracking this via https://github.com/Microsoft/ChakraCore/issues/2787

boingoing avatar Jul 11 '18 00:07 boingoing

dotAll is now in chakracore master https://github.com/Microsoft/ChakraCore/pull/5592 - assumedly need to wait for the next CC release for it to be in a release branch though.

rhuanjl avatar Sep 20 '18 11:09 rhuanjl

Yup, we'll pick this up in vNext.

kfarnung avatar Sep 20 '18 17:09 kfarnung