node-chakracore icon indicating copy to clipboard operation
node-chakracore copied to clipboard

build: fix ./configure --xcode failure

Open tommyZZM opened this issue 8 years ago • 3 comments

make ./configure --xcode is able to generate .xcodeproj and build all targets successfully

reference: https://github.com/nodejs/node-chakracore/issues/297

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
Affected core subsystem(s)

None

tommyZZM avatar Aug 20 '17 13:08 tommyZZM

I guess that you assume this work if you have compiled chakracore already? And don't include ChakraCore in xcode?

obastemur avatar Aug 20 '17 20:08 obastemur

hi @obastemur

chakracore.xcodeproj and chakrashim.xcodeproj are both included and compile by xcode successfully

tommyZZM avatar Aug 21 '17 13:08 tommyZZM

chakracore.xcodeproj and chakrashim.xcodeproj are both included and compile by xcode successfully

They are there because of chakracore.gyp and chakrashim.gyp are exist. ChakraCore build system is CMake. You can't create chakracore's xcode project by exporting xcode from gyp.

Besides, the changes to configure needs some attention.

Thanks for the attempt.

This; being automated, may require a bit more hacking.

obastemur avatar Aug 22 '17 11:08 obastemur