node-chakracore icon indicating copy to clipboard operation
node-chakracore copied to clipboard

Build fails to recognize changes in deps/chakrashim/core and re-build

Open obastemur opened this issue 9 years ago • 1 comments

node-chakracore/xplat branch.

Two problems;

1 - Updating code (c/c++..) under deps/chakrashim/core doesn't trigger chakrashim build. This is expected since we use CMake build from sub bash process. However, we better fix this because it's confusing / miss-leading and buggy.

2 - In order to trigger chakrashim build (so the core build), update one of the chakrashim source files. My expectation here is that, core build is going to be triggered and then its output is going to be linked into final node binary. This also fails.

My current workaround was to visit deps/chakrashim/core/out/Release and call make prior to calling make from node-chakracore root.

obastemur avatar Mar 02 '17 13:03 obastemur

Currently for non-win32, chakracore is always built using Release. Address to build the flavor based on what was passed to ./configure.

kunalspathak avatar Mar 21 '17 15:03 kunalspathak