node-addon-examples icon indicating copy to clipboard operation
node-addon-examples copied to clipboard

Usage of deprecated functions

Open robinchrist opened this issue 6 years ago • 2 comments

Hi,

It is currently not possible to build the NAN examples, because lines like cons->NewInstance(argc, argv) are frequently used. However, NewInstance is deprecated and Nan::NewInstance(cons, argc, argv).ToLocalChecked() or similar should be used instead (see https://stackoverflow.com/questions/45388032/how-to-silence-newinstance-is-deprecated-warning-in-node-gyp-rebuild-what)

I will try to fix this, but I'm just a beginner with NAN/Node...

robinchrist avatar Jan 29 '19 13:01 robinchrist

@robinchrist thanks most of those active in this repo are focussed on the N-API versions of the examples so your help is appreciated.

mhdawson avatar Jan 30 '19 18:01 mhdawson

@robinchrist I should have also mentioned that work on the examples has moved to : https://github.com/nodejs/node-addon-examples

I need to get this repo archived.

mhdawson avatar Jan 30 '19 18:01 mhdawson