node-addon-examples icon indicating copy to clipboard operation
node-addon-examples copied to clipboard

Multiple classes (wrapped objects)

Open johnsauer99 opened this issue 3 years ago • 4 comments

My problem is multiple classes (objects) exported via my Init() functions. I have two classes that I want to use in my javascript but the 'constructor' seems to be overwritten with whoever gets Init()'d i.e.:

// This code is present in both classes Init() method: Napi::FunctionReference* constructor = new Napi::FunctionReference(); *constructor = Napi::Persistent(func); env.SetInstanceData(constructor); exports.Set("Dataset", func);

Question: Is it possible to export have more than one class object??

johnsauer99 avatar Apr 01 '21 20:04 johnsauer99

I'm not quite sure what you mean by "class" in this context. There should only be one Napi::Addon instance for a given addon.

You can create multiple Napi::Object wrap instances.

mhdawson avatar Apr 16 '21 18:04 mhdawson

Related issue https://github.com/nodejs/node-addon-examples/issues/171

ikokostya avatar May 02 '21 12:05 ikokostya

@mhdawson Many examples in this repository repeat the following code snippet:

Napi::FunctionReference* constructor = new Napi::FunctionReference();
*constructor = Napi::Persistent(func);
env.SetInstanceData(constructor);

So only one data item can be associated with the current instance of the addon. In our case only one constructor. This works only for examples which contain single object wrap. Please see #171 for more details.

ikokostya avatar May 02 '21 13:05 ikokostya

You are correct that only one data item can be associated with the current instance. Y

You can make what you set through env.SetIntsanceData a struct so that it can hold multiple C level pointers. Or possibly a linked list. If you make it a linked list then you could use GetInstanceData to get the current value set. If it is Null create the initial entry and set it, if it is not null then add to the linked list. At shutdown you'd then need to walk the list and do the right thing for each entry.

mhdawson avatar May 03 '21 21:05 mhdawson