node-addon-api

node-addon-api copied to clipboard

AsyncProgressQueueWorker::Signal() does not trigger the TSFN

8

As reported in https://github.com/nodejs/node-addon-api/pull/1086#issue-1017797535

KevinEady

A mirror of pr https://github.com/nodejs/node-addon-api/pull/1196, but for `ThreadSafeFunction` class

JckXia

src: fix implementation of AsyncProgressWorker::Signal

2

Fix implementation of `AsyncProgressWorker::Signal` and `AsyncProgressQueueWorker::Signal` Fixes: #1095 Fixes: #1081

KevinEady

unbounded memory usage in unyielding JS jobs creating ObjectWrap-ed native objects

10

See this [minimal reproduction repository](https://github.com/MichaelBelousov/leaky-nodeaddon-repro). When creating several instances of a C++ object that is wrapped by `ObjectWrap`, memory usage goes up forever unless the JavaScript job yields. Even though...

MichaelBelousov

AsyncWorker pass Napi::Object problem?

1

I want to pass in the object as a parameter I get error "Fatal error in HandleScope::HandleScope" "Entering the V8 API without proper locking in place" example ```cpp class TestWorker...

tak40548798

Hello, Thanks to this [post](https://jakecyr.medium.com/saving-javascript-callbacks-with-node-addon-api-3c6e804aa367), I was able to embed a simple event listener in my class. Basically, on JS call of a static `On` method, my wrapped class records...

benoitlahoz

This is not strictly an issue, more a **performance** issue... point me to a better location where to post this, if it's not the right place... I could not find...

ggreco

We discussed on the 7 Oct Node API meeting: There have been several PRs that have been merged (or waiting to be merged) that fix behavior of APIs. We should...

KevinEady

Object wrap has a memory leak bug?

23

I have got several memory leak issues with this addon library. I thought it was me who wrote the code wrong. But when I am trying to run this example,...

ammarfaizi2

test: Add test coverage to TSFN::New() overloads

2

Adding test coverage for `TSFN::New` overloads where we provide the async resource name and/or the async resource object but no finalizer callbacks.

JckXia