nan icon indicating copy to clipboard operation
nan copied to clipboard

strings-test.js fails on s390x

Open bryceharrington opened this issue 2 years ago • 0 comments

We're running into this in Ubuntu's 22.04 CI: https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/s390x/n/node-nan/20220306_113841_a17b2@/log.gz

534 passing (12s) 1 failing

  1. test/js/strings-test.js FromV8String should be equal:

    Error: should be equal

    • expected - actual

    -栀攀氀氀漀 +hello

    at Test. (test/js/strings-test.js:36:5) at Object. (test/js/strings-test.js:14:1)

I wonder if this might be an endian issue with the usage of the Buffer class? We can disable the test but a fix/workaround would be most appreciated.

bryceharrington avatar Apr 02 '22 02:04 bryceharrington