nan icon indicating copy to clipboard operation
nan copied to clipboard

The 'request' packages is not used?

Open ip1981 opened this issue 6 years ago • 1 comments

There is a dev dependency in package.json - "request": "=2.81.0", but I don't see it's used anywhere.

ip1981 avatar Oct 12 '19 19:10 ip1981

That's to pin down the version of request that's used by node-gyp. There was a change in [email protected] that breaks old Node.js versions. See commit 4525cbc4.

As a node-gyp maintainer, I'd say depending on a specific version of node-gyp rather than what is shipped with npm is kind of an anti-pattern but hey.

bnoordhuis avatar Oct 13 '19 11:10 bnoordhuis