Add required compiler versions in the error msg

[apaatsio]

Save the users a Google search and tell them what compiler version they need.

See: https://github.com/nodejs/nan/issues/448

[rvagg]

This would need an MSVC version too for completeness

[kkoopa]

I do not like it. Listing versions explicitly is too much detail. There can still be discrepancies, compiler bugs, vendors not applying the right patches, wrong flags and so on. Not to mention that no version of msvc truly has proper C++11 support yet.

The code which produces the error message mostly relies on feature detection, and it is merely there as convenience to limit the number of frivolous issues due to not grokking the compiler error which would be produced otherwise. What will happen when the next compiler comes along and is not listed?

On Thursday 28 January 2016 02:29:44 Antti Ahti wrote:

Save the users a Google search and tell them what compiler version they need.

See: https://github.com/nodejs/nan/issues/448 You can view, comment on, or merge this pull request online at:

https://github.com/nodejs/nan/pull/536

-- Commit Summary --

• Add required compiler versions in the error msg

-- File Changes --

M nan.h (2)

-- Patch Links --

https://github.com/nodejs/nan/pull/536.patch https://github.com/nodejs/nan/pull/536.diff

---

Reply to this email directly or view it on GitHub: https://github.com/nodejs/nan/pull/536

[apaatsio]

Yeah, it's a trade-off between "more useful error message for most users" and "not so useful but accurate error message"

[ranisalt]

Clang 3.3 has full C++11 support already, but Nan probably can be compiled with Clang 3.1 since patches 3.2 and 3.3 are not very used (source)

[agnat]

I'm with @kkoopa on this. We (try to) point the user in a clear direction. Maintaining a list of working compilers is beyond our scope.