llparse icon indicating copy to clipboard operation
llparse copied to clipboard

chore: remove abort

Open Uzlopak opened this issue 1 year ago • 2 comments

I dont know what the point is to have this unreachable code in the result. It increases the size of the generated wasm files.

Uzlopak avatar Aug 27 '24 09:08 Uzlopak

@mcollina @ShogunPanda

Uzlopak avatar Aug 27 '24 10:08 Uzlopak

@indutny Any hint on this?

ShogunPanda avatar Aug 27 '24 10:08 ShogunPanda

The point of these unreachable is to help guide compiler through the difficult code. I agree that we can save some space by not doing abort() calls. Here's a different approach https://github.com/nodejs/llparse/pull/76

indutny avatar Apr 20 '25 16:04 indutny