llnode icon indicating copy to clipboard operation
llnode copied to clipboard

no coverage for "v8 nodeinfo"

Open kvakil opened this issue 3 years ago • 4 comments

According to the coverage report there are no tests for v8 nodeinfo. Two options:

  1. Remove it. It is a couple hundred lines of code, and how often do you get a coredump where you don't know the version of Node.js you were running?
  2. Add a test for it.

kvakil avatar Oct 01 '22 02:10 kvakil

(Apparently I can't label issues here, but this is https://github.com/nodejs/llnode/labels/good%20first%20issue.)

kvakil avatar Oct 01 '22 02:10 kvakil

Funny enough not having the right node version is a common error even among experienced developers so I would aim for adding a test.

No9 avatar Oct 01 '22 06:10 No9

Also I'm at collab summit today I'll confirm with @mhdawson best way to formally add you to the repo so you can edit labels etc

No9 avatar Oct 01 '22 06:10 No9

@No9 The governance for a team/related repo is generally set by the team itself. I do see that there is governance specified in this repo but it is wa....y out of date.

It might be good to update that and at this point it would probably be ok to keep it simple, maybe something that just says existing collaborators can add new collaborators when/if appropriate.

mhdawson avatar Oct 14 '22 22:10 mhdawson