llnode icon indicating copy to clipboard operation
llnode copied to clipboard
verified publisher icon nodejs

discussion: Re-establish automation to detect breaking changes

Open No9 opened this issue 3 years ago • 2 comments

As per https://github.com/nodejs/llnode/issues/287#issuecomment-1250090957 the core project used to detect breaking changes but this has been removed. This issue is to track conversation on how the llnode project can either re-establish the tests here or provide other mitigation.

No9 avatar Sep 17 '22 15:09 No9

@kvakil Would like to get you're thoughts on this. Do you think there is value in detecting V8 changes explicitly or should we rely on testing with up coming releases as per your PR https://github.com/nodejs/llnode/pull/420?

No9 avatar Sep 25 '22 09:09 No9

I think if we get testing of nightly + v8-canary working we'll get largely the same benefit as having the test upstream. We can have it run on a daily schedule and get notifications for when it fails.

This increases the chances that we roll out a version of Node.js which does not support llnode (e.g. if nobody fixes the failure in time). This is fine -- I don't think llnode failures should block Node.js releases.

kvakil avatar Sep 25 '22 20:09 kvakil