http-parser
http-parser copied to clipboard
CMake support
Hi, I'm going to write CMakeLists.txt for http-parser to use it in my project. I could put a bit more effort into it (add tests support, install step, etc.) if you are interested in merging CMake support in. I see that http-parser also has Make and GYP support, and having third build system could be too much. What do you think about it?
+1
2015-07-02 21:45 GMT+03:00 wonder-mice [email protected]:
Hi, I'm going to write CMakeLists.txt for http-parser to use it in my project. I could put a bit more effort into it (add tests support, install step, etc.) if you are interested in merging CMake support in. I see that http-parser also has Make and GYP support, and having third build system could be too much. What do you think about it?
— Reply to this email directly or view it on GitHub https://github.com/joyent/http-parser/issues/257.
Regards, Konstantin
Considering that there not going to be much build changes, I'm totally fine with it. Please go ahead! ;)
Thanks.
+1
@wonder-mice ... is this still something you're interested in?
:+1:
Yes, I have it almost ready, but can't find enough time to groom it before publishing.
Similarly, any interest in a pkg-config file? (.pc)?
Any news ?
Sent out a pull request with a minimal CMake build. It only provides static and shared instances of the main library target, but I think it will be more productive to start basic and iterate from there rather than waiting for a complete port of all the Makefile targets, etc.
There are now two PR's adding cmake support. Would @bnoordhuis or anyone else be willing to validate/rebase and merge one of them?