http-parser icon indicating copy to clipboard operation
http-parser copied to clipboard

CMake support

Open wonder-mice opened this issue 9 years ago • 10 comments

Hi, I'm going to write CMakeLists.txt for http-parser to use it in my project. I could put a bit more effort into it (add tests support, install step, etc.) if you are interested in merging CMake support in. I see that http-parser also has Make and GYP support, and having third build system could be too much. What do you think about it?

wonder-mice avatar Jul 02 '15 18:07 wonder-mice

+1

2015-07-02 21:45 GMT+03:00 wonder-mice [email protected]:

Hi, I'm going to write CMakeLists.txt for http-parser to use it in my project. I could put a bit more effort into it (add tests support, install step, etc.) if you are interested in merging CMake support in. I see that http-parser also has Make and GYP support, and having third build system could be too much. What do you think about it?

— Reply to this email directly or view it on GitHub https://github.com/joyent/http-parser/issues/257.

Regards, Konstantin

Lupus avatar Jul 02 '15 18:07 Lupus

Considering that there not going to be much build changes, I'm totally fine with it. Please go ahead! ;)

Thanks.

indutny avatar Jul 04 '15 03:07 indutny

+1

r3n4ud avatar Jul 06 '15 18:07 r3n4ud

@wonder-mice ... is this still something you're interested in?

jasnell avatar Oct 26 '15 21:10 jasnell

:+1:

RWOverdijk avatar Mar 08 '16 22:03 RWOverdijk

Yes, I have it almost ready, but can't find enough time to groom it before publishing.

wonder-mice avatar Mar 09 '16 06:03 wonder-mice

Similarly, any interest in a pkg-config file? (.pc)?

rfdickerson avatar Apr 29 '16 21:04 rfdickerson

Any news ?

grobx avatar May 23 '16 23:05 grobx

Sent out a pull request with a minimal CMake build. It only provides static and shared instances of the main library target, but I think it will be more productive to start basic and iterate from there rather than waiting for a complete port of all the Makefile targets, etc.

flandr avatar Jun 28 '17 04:06 flandr

There are now two PR's adding cmake support. Would @bnoordhuis or anyone else be willing to validate/rebase and merge one of them?

solvingj avatar Jan 01 '19 21:01 solvingj