gyp-next icon indicating copy to clipboard operation
gyp-next copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

chore: fix XCConfigurationList assertion

Open legendecas opened this issue 1 year ago • 2 comments

Fix tests.

Weirdly, GitHub action didn't run for https://github.com/nodejs/gyp-next/pull/263 and it showed green to be merged. I enabled the following settings for the repo to avoid accidental merge if GitHub action was not triggered.

  • Require status checks to pass before merging, and
  • Require branches to be up to date before merging (the original PR needs to be updated with the main branch before merging so that we don't have to fixup again).

legendecas avatar Jul 01 '24 09:07 legendecas

Either line 7 or line 9 (I never remember which) of .github/workflows/python_tests.yml should be removed so that GHA's run for PRs from project maintainers.

cclauss avatar Jul 01 '24 10:07 cclauss

Either line 7 or line 9 (I never remember which) of .github/workflows/python_tests.yml should be removed so that GHA's run for PRs from project maintainers.

Updated!

Now for outdated PRs, GitHub UI shows as:

image

legendecas avatar Jul 01 '24 10:07 legendecas

@cclauss would you mind taking a look at this so that the CI on PRs like https://github.com/nodejs/gyp-next/pull/266 can be fixed? Thanks!

legendecas avatar Sep 02 '24 11:09 legendecas

I usually push to my own fork repo so I'd bet it won't be triggered for my branches in duplication.

legendecas avatar Sep 02 '24 11:09 legendecas