gyp-next icon indicating copy to clipboard operation
gyp-next copied to clipboard

fix: duplicate ninja rules for v8 (cross-compiling)

Open moto-timo opened this issue 2 years ago • 7 comments

avoids duplicate ninja rules for v8 used in host and target

From: https://github.com/minrk/node/commit/5e533cb943eef68b270f55f0cba02c0ec67c699d

Reported in https://github.com/nodejs/node/issues/46690 and https://github.com/nodejs/node/issues/37441

moto-timo avatar Feb 18 '23 22:02 moto-timo

Please rebase.

cclauss avatar Feb 19 '23 13:02 cclauss

Rebased again.

moto-timo avatar Feb 20 '23 17:02 moto-timo

Rebased to pick up the xml.etree.cElementTree commit.

moto-timo avatar Feb 20 '23 17:02 moto-timo

@cclauss I believe I addressed your recommendations and rebase concerns. Anything else that needs to be done or any more discussion?

moto-timo avatar Feb 23 '23 16:02 moto-timo

This pull request is rebased and the tests are all green. ✅ Thanks for that.

Now what we need is some maintainer who has enough expertise to review and approve or make suggestions.

cclauss avatar Feb 23 '23 16:02 cclauss

@cclauss great. Thank you for the response.

moto-timo avatar Feb 23 '23 16:02 moto-timo

I can confirm that this goes with the default naming conventions of depot_tools and ninja, but I'd let someone else approve it for sure.

ryzokuken avatar Feb 24 '23 10:02 ryzokuken