GitHub webhook not restarting the server?

[mmarchini]

So I merged #275 today, but the bot was still behaving like before the PR. I just logged into the bot instance and noticed the bot server was running since Aug 9 0:06 UTC, the PR was merged at Aug 9 21:07 UTC. The repository folder was correctly updated, but the server didn't restart to apply the changes. Is the server supposed to restart when a new commit is merged, or does it restart once a day (or only manually)?

[phillipj]

Hmz, strange. It is supposed to restart as soon as commits lands to master, here is the relevant github-webhook configuration in the build repo:

• github-bot-deploy-webhook.service
• github-bot-deploy-webhook.json

I've noticed blipps of it not working from time to time, both for the github-bot and in nodejs.org which has a very similar github-webhook setup.

Looking at the webhook events log under this repo' Settings-page doesn't give any valuable hints either. The two most recent push events sent to the github-bot server succeeded:

Bottom line; I don't know why it didn't restart. Let's keep an eye on it going forward and dig deeper if the issue persists?