docs: update nodejs versions to 22 in README.md
Description
Updated node:8 and node:16 image tags to node:22 in README.
Motivation and Context
As a developer, I would like to see latest LTS version in the documentation.
Types of changes
- [x] Documentation
- [ ] Version change (Update, remove or add more Node.js versions)
- [ ] Variant change (Update, remove or add more variants, or versions of variants)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Other (none of the above)
Checklist
- [ ] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [x] I have updated the documentation accordingly.
- [x] I have read the CONTRIBUTING.md document.
- [ ] All new and existing tests passed.
I'm also thinking about updating docker compose example too. Is it OK to do it in this PR?
services:
node:
image: "node:22"
environment:
- NODE_ENV=production
volumes:
- ./:/home/node/app
ports: # use if it is necessary to expose the container to the host machine
- "8081:8081"
command: ["npm", "start"]
I'm also thinking about updating docker compose example too. Is it OK to do it in this PR?
services: node: image: "node:22" environment: - NODE_ENV=production volumes: - ./:/home/node/app ports: # use if it is necessary to expose the container to the host machine - "8081:8081" command: ["npm", "start"]
Yes please 🙂
@coderabbitai, could you provide a better PR subject and description?
Summary from GitHub Copilot:
This pull request updates the Node.js version used in the Docker configurations and examples within the
README.mdfile. The changes ensure consistency across the documentation and upgrade the Node.js version to22.Updates to Node.js version in Docker configurations:
- Updated the Node.js base image in the Dockerfile example from
node:16tonode:22. (README.md, README.mdL55-R55)- Modified the Docker Compose example to use
node:22as the image, updated the exposed port to8888, and adjusted the command syntax to use an array format. (README.md, README.mdL70-R79)- Updated the standalone Docker command example to use
node:22instead ofnode:8. (README.md, README.mdL108-R103)
Hi @PeterDaveHello I updated the title and description. Sorry for the untested changes like deleting user and working_dir specifications. I suggest accepting the Copilot's commit https://github.com/nodejs/docker-node/pull/2243#discussion_r2247770240
@mertssmnoglu no problem, just let me know when it's ready.
@mertssmnoglu no problem, just let me know when it's ready.
It's ready right now.