docker-node icon indicating copy to clipboard operation
docker-node copied to clipboard

Node.js process does not exit when unhandled promise rejection occured

Open MengLi619 opened this issue 10 months ago • 2 comments

Environment

  • Platform: Azure AKS
  • Docker Version: Unknown
  • Node.js Version: 18.19.0
  • Image Tag: node:18.19.0-alpine3.17

Expected Behavior

Node.js process should exit when unhandled promise rejection occurs

Current Behavior

Node.js process does not exit when unhandled promise rejection occurs

Possible Solution

Node.js process should exit because it's the default behavior after node.js 15, we depend on this behavior to restart and retry to finish the application startup process.

Steps to Reproduce

During the startup process, after an unhandled rejection is thrown, the node.js process does not exit.

Additional Information

MengLi619 avatar Feb 06 '25 02:02 MengLi619

I'm not getting this behavior.

% docker run --rm node:18.19.0-alpine3.17 -e 'Promise.reject("test")'
node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "test".] {
  code: 'ERR_UNHANDLED_REJECTION'
}

Node.js v18.19.0
% echo $?                                                            
1

Perhaps this has to do with how your container is run.

LaurentGoderre avatar Feb 06 '25 14:02 LaurentGoderre

@LaurentGoderre Thanks a lot, just figured out the problem is caused by Sentry, after calling Sentry.init, The app was presented to crash even unhandledRejection was raised.

MengLi619 avatar Feb 26 '25 09:02 MengLi619