docker-node icon indicating copy to clipboard operation
docker-node copied to clipboard

Update Node.js release signing keys

Open richardlau opened this issue 1 year ago • 1 comments

Description

Fixes the Node.js release signing key update script to account for upstream Node.js changes:

  • Node.js HEAD branch is now main
  • Comments added to each line in the key list (https://github.com/nodejs/node/pull/52878)

Syncs the list of Node.js release signing keys by running the updated script.

Remove @MylesBorins' key as he has stepped down from the releasers team.

Motivation and Context

I'm going through the Node.js releaser off-boarding steps for Myles and removing his key from this repository is one of the offboarding steps.

In general keeping the list of Node.js release signing keys is good practice.

Testing Details

Example Output(if appropriate)

Types of changes

  • [ ] Documentation
  • [ ] Version change (Update, remove or add more Node.js versions)
  • [ ] Variant change (Update, remove or add more variants, or versions of variants)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] Other (none of the above)

Checklist

  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING.md document.
  • [ ] All new and existing tests passed.

richardlau avatar Jul 26 '24 16:07 richardlau

Would it make sense to have a cron job that runs this script regularly so we get automated PRs? Similar to how we get node updates

SimenB avatar Jul 29 '24 08:07 SimenB

Can this land?

richardlau avatar Sep 25 '24 16:09 richardlau

Of course, sorry!

SimenB avatar Sep 25 '24 16:09 SimenB