docker-node icon indicating copy to clipboard operation
docker-node copied to clipboard

feat: drop arm32v7 buster for Node 20

Open nschonni opened this issue 2 years ago • 6 comments

Description

Need to confirm that this is required in #1885 so opening as draft for now

Motivation and Context

Testing Details

Example Output(if appropriate)

Types of changes

  • [ ] Documentation
  • [ ] Version change (Update, remove or add more Node.js versions)
  • [ ] Variant change (Update, remove or add more variants, or versions of variants)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Others (non of above)

Checklist

  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING.md document.
  • [ ] All new and existing tests passed.

nschonni avatar Apr 21 '23 22:04 nschonni

I replied in https://github.com/nodejs/docker-node/issues/1885#issuecomment-1518665007 -- Node.js 20 should be okay in a standard Debian Buster container on all platforms except for armv7l.

FWIW It is possible to run the Node.js 20 armv7l binaries in the 10-buster image from https://hub.docker.com/r/arm32v7/gcc.

richardlau avatar Apr 22 '23 13:04 richardlau

With that information, I'd vote to only drop arm32v7 from the Node.js 20 images on buster.

On the other hand, the next stable release of Debian is "soon" (bookworm is currently at the "Hard Freeze" stage) so maybe fully dropping buster on 20.x and only doing the two most-recent Debian releases would be better (one until the Bookworm release). 🤔 🤷

buster is currently under "Debian LTS", so it already has a constrained set of architectures.

yosifkit avatar Apr 24 '23 23:04 yosifkit

I've updated it to just drop the arm32v7 instead of fully dropping buster

nschonni avatar Apr 25 '23 01:04 nschonni

FWIW the commit message has a typo, "arm34v7" instead of "arm32v7".

richardlau avatar Apr 25 '23 11:04 richardlau

FWIW the commit message has a typo, "arm34v7" instead of "arm32v7".

Thanks, fixed

nschonni avatar Apr 25 '23 16:04 nschonni

Is this waiting on anything in particular?

SimenB avatar Sep 08 '23 08:09 SimenB

@SimenB Any chance this will get merged? As it stands the arm32v7/node docker image can't be used :(

joshuawwright avatar Apr 19 '24 22:04 joshuawwright

@nschonni is it good to go?

SimenB avatar Apr 22 '24 15:04 SimenB

Created PR on the official-images repo (https://github.com/docker-library/official-images/pull/16641). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

github-actions[bot] avatar Apr 22 '24 19:04 github-actions[bot]