docker-node icon indicating copy to clipboard operation
docker-node copied to clipboard

Add an example of how to create smaller images without npm/yarn

Open zsolt-dev opened this issue 1 year ago • 3 comments

Only changes the documentation...

zsolt-dev avatar Sep 16 '22 12:09 zsolt-dev

I have looked into the failing steps and they do not seem to be caused by my code changes.

zsolt-dev avatar Sep 16 '22 12:09 zsolt-dev

Hi,

The first check is failing because of an external issue. The second check is failing because of a trailing whitespace in your PR (see my review below).

The rest seems fine.

Thanks

SomaticIT avatar Sep 16 '22 14:09 SomaticIT

@SomaticIT @yosifkit

Can we please merge it? All the issues except the missing NODE_VERSION env are resolved.

Since it is only a documentation change of an example, I would merge it like it is, unless someone figures out an elegant/short code to add the ENV back.

Thank you

zsolt-dev avatar Sep 23 '22 10:09 zsolt-dev

@SomaticIT

Thank you for your input.

I refactored the second stage based on your input.

Hovewer I have left the build stage in separate commands since I believe it is the best practice to first copy only the package.json and do an npm i first. So that if the package.json does not change, only the code, it skips the step.

Please review.

zsolt-dev avatar Sep 28 '22 12:09 zsolt-dev

Good for me

SomaticIT avatar Sep 28 '22 19:09 SomaticIT

@yosifkit, @nschonni, @astellingwerf

One more review is required for the merge. Would anyone please review? Thank you

zsolt-dev avatar Oct 15 '22 10:10 zsolt-dev