docker-node icon indicating copy to clipboard operation
docker-node copied to clipboard

create a tag for minimal supported version.

Open gengjiawen opened this issue 5 years ago • 11 comments

This will help lib authors to keep compatibility check without to change version after a version deprecated.

gengjiawen avatar Mar 02 '20 08:03 gengjiawen

I'm not sure I understand what you're asking for, can you try explaining it further? EX: there are tags for things like LTS and their code names https://registry.hub.docker.com/_/node/

nschonni avatar Mar 02 '20 21:03 nschonni

I want a tag for lowest supported Node.js version. Current is 10. like node: minimal point to it.

gengjiawen avatar Mar 03 '20 01:03 gengjiawen

so basically the opposite of latest, seems like a valid use case

DRoet avatar Mar 05 '20 10:03 DRoet

I am hesitant to introduce a tag that isn't standard in either docker or nodejs. We tag based on what the core node project uses.

LaurentGoderre avatar Mar 05 '20 13:03 LaurentGoderre

I believe there has been some discussions on the general support strategy about versions and how to achieve it over in https://github.com/nodejs/package-maintenance I'm also 👎 to adding this as a tag though.

nschonni avatar Mar 05 '20 19:03 nschonni

@rvagg is this something the core Node project ever consider using?

LaurentGoderre avatar Mar 06 '20 16:03 LaurentGoderre

The only way I can think of to consume such a tag would be with travis or github actions, but I don't think pushing that via docker is going to help much. It's really something you'd want nvm to support. 🤷‍♂

rvagg avatar Mar 09 '20 03:03 rvagg

I am hesitant to introduce a tag that isn't standard in either docker or nodejs. We tag based on what the core node project uses.

I don't see this argument. dubnium is quite as useless for most users and still it is applied. 10 is available either, currently. lts is used as is current or lts with neither of the two being usually available in docker repositories. And I don't see why offering a whole set of basically outdated major releases of Node.js at all when there is no reason for providing some useful tag to address this major release in opposition to the upcoming one and the LTS one.

In my case (#1240) I'm implementing several software packages each relying on CI for testing either package against latest, current or lts and whatever is available in addition without ever having to change the CI configuration whenever Node.js is switching from one major to another. I think as long as there are images provided for "old stable" there should be an opportunity for CIs to test against those packages as easy as possible as well. That's why I don't think minimal is a desirable candidate as it is suggesting use of outdated major version to be considered sufficient. Instead, I suggest using old.

soletan avatar Apr 09 '20 08:04 soletan

It's not hard to add but I don't want add semantic problems. For example old could be confused as EOL so the name of the tag is somewhat important.

LaurentGoderre avatar Apr 13 '20 14:04 LaurentGoderre

So, what about previous to accompany current, though previous-lts would be a better fit?

soletan avatar Apr 14 '20 11:04 soletan

I think this is a valid use case. tag changes all over the time. like latest, I think user can expect this. Only number are accurate in this case.

gengjiawen avatar Apr 14 '20 12:04 gengjiawen