core-validate-commit icon indicating copy to clipboard operation
core-validate-commit copied to clipboard

Invalid Commit Message

Open H4ad opened this issue 1 year ago • 1 comments

This PR was merged with a non-imperative verb starting the commit message: benchmark: added new benchmarks for blob.

From what the docs says, it should be a invalid message.

The CI did raised an error about the length (that I fix) but didn't raise an error about this verb and it was merged.

H4ad avatar Oct 04 '23 01:10 H4ad

It is extremely difficult to automatically and reliably determine whether a commit message follows our commit message guidelines exactly. In the end, it is the collaborators' responsibility to only merge commits that follow the guidelines.

tniessen avatar Oct 05 '23 09:10 tniessen