citgm icon indicating copy to clipboard operation
citgm copied to clipboard

nan tests fail on three platforms with Node.js 20.x

Open Trott opened this issue 2 years ago • 2 comments

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3297/testReport/ shows failures on win-vs2019, rhel8-s390x, and aix72-ppc64. Is someone likely to investigate these any time soon or would it be best to skip on those platforms for now? (Honest question, no judgment, just trying to figure out the best path forward.)

@nodejs/addon-api @nodejs/citgm

Trott avatar Oct 01 '23 23:10 Trott

The rhel8-s390x and aix72-ppc64 failures are https://github.com/nodejs/nan/issues/935 and almost certainly an endianness problem (no idea how easy it will be to fix).

richardlau avatar Oct 02 '23 18:10 richardlau

@Trott unfortunately it is not bound to v20.x. It also failed in this run with v18.18.

Shall we skip it for these platforms for now until a proper solution is found? (#1005)

alfonsograziano avatar Oct 08 '23 06:10 alfonsograziano