lookup: re-add express

[Trott]

Checklist

• [x] npm test passes
• [x] contribution guidelines followed here

[codecov-commenter]

Codecov Report

Patch and project coverage have no change.

Comparison is base (f15c9a2) 96.44% compared to head (95c59bf) 96.44%. Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #977   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          28       28           
  Lines        2139     2139           
=======================================
  Hits         2063     2063           
  Misses         76       76           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[targos]

https://github.com/nodejs/citgm/actions/runs/6298376266

[targos]

Tests don't pass with Node.js 20.x

[UlisesGascon]

Could we please re-run the test? Unfortunately, I don't have the necessary permissions, and the logs seem to have been cleared

[targos]

You can do it locally with citgm express. Error is:

error:                     | with strict option
error:                     | when undefined
error:                     | should 400 on primitives:
error:                     | Error: expected `[entity.parse.failed] Unexpected token 't', "#rue" is not valid JSON` response body, got `[entity.parse.
error:                     | at Context.<anonymous> (test/express.json.js:265:12)
error:                     | at process.processImmediate (node:internal/timers:478:21)
error:                     | ----
error:                     | at error (node_modules/supertest/lib/test.js:335:15)
error:                     | at Test._assertBody (node_modules/supertest/lib/test.js:206:16)
error:                     | at /private/var/folders/9n/05y6s4ls78515vmnbd86hktm0000gn/T/aa94096d-a5a6-47ef-ab19-b655dcf35b66/express/node_modules/sup
error:                     | at Test._assertFunction (node_modules/supertest/lib/test.js:285:13)
error:                     | at Test.assert (node_modules/supertest/lib/test.js:164:23)
error:                     | at Server.localAssert (node_modules/supertest/lib/test.js:120:14)
error:                     | at Object.onceWrapper (node:events:632:28)
error:                     | at Server.emit (node:events:518:28)
error:                     | at emitCloseNT (node:net:2279:8)
error:                     | at process.processTicksAndRejections (node:internal/process/task_queues:81:21)
error: done                | The smoke test has failed.

[UlisesGascon]

The next Express release will solve the problem. I will update the maintainers list also in this PR once the release is ready 👍

[UlisesGascon]

Good news! 🥳

The CI is green again. The last release v4.18.3 just patch the issue. Also I added @wesleytodd, @sheplu and myself as maintainers.

[RafaelGSS]

@UlisesGascon can you trigger CI again before merging it?

[UlisesGascon]

@UlisesGascon can you trigger CI again before merging it?

I did a small amend, so the run is https://github.com/nodejs/citgm/actions/runs/8109083937/job/22163557478 and passing. No more changes expected from my side, so we can merge it when you are ready @RafaelGSS

[targos]

Full CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/239/

[UlisesGascon]

Full CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/239/

Not sure why osx11 is having some errors with Junit, but seems not related to express. 🤔

[targos]

Actual error is:

11:16:22 /var/folders/qn/tzmmkdsj1b1__zpsd02jn7x80000gp/T/jenkins11590088253155342208.sh: line 34: /Users/iojs/build/workspace/citgm-smoker-nobuild/node/bin/node: Bad CPU type in executable

Tracked by https://github.com/nodejs/citgm/issues/1042

This can land.

[UlisesGascon]

This can land.

Thanks for the analysis @targos 👍

@RafaelGSS if you are ok with the changes, I will land the PR :)