citgm icon indicating copy to clipboard operation
citgm copied to clipboard

chore: update all dependencies

Open targos opened this issue 2 years ago • 6 comments

Breaking changes are mainly dropping support for Node.js 12 and 14 (which we already stopped supporting), and API switch from callback to promises.

targos avatar Mar 07 '23 15:03 targos

I can reproduce the failures with v14. Will investigate.

targos avatar Mar 07 '23 15:03 targos

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.12 :tada:

Comparison is base (9975077) 93.20% compared to head (6b03830) 95.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
+ Coverage   93.20%   95.33%   +2.12%     
==========================================
  Files          28       28              
  Lines        2149     2143       -6     
==========================================
+ Hits         2003     2043      +40     
+ Misses        146      100      -46     
Impacted Files Coverage Δ
lib/citgm.js 100.00% <100.00%> (+15.78%) :arrow_up:
lib/grab-project.js 96.03% <100.00%> (+0.03%) :arrow_up:
lib/package-manager/get-executable.js 100.00% <100.00%> (ø)
lib/package-manager/test.js 99.35% <100.00%> (-0.01%) :arrow_down:
lib/temp-directory.js 100.00% <100.00%> (+4.25%) :arrow_up:
lib/unpack.js 95.55% <100.00%> (+0.10%) :arrow_up:
lib/spawn.js 23.07% <0.00%> (-76.93%) :arrow_down:
lib/bin/citgm-all.js 94.53% <0.00%> (+5.04%) :arrow_up:
lib/match-conditions.js 94.00% <0.00%> (+6.00%) :arrow_up:
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Mar 07 '23 15:03 codecov-commenter

It was just that stream.promises don't exist in v14.x

targos avatar Mar 08 '23 07:03 targos

Windows fails everywhere, not sur I'll be able to debug this one.

targos avatar Mar 08 '23 07:03 targos

Ironically, the changelog for rimraf@4 has:

Windows performance and reliability improved.

targos avatar Mar 26 '23 09:03 targos

    # Subtest: tempDirectory.remove: bad path
        1..1
    MESSAGE refusing to remove root directory without preserveRoot:false
        not ok 1 - the message should include the path \\\\.\\NUL
          ---
          at:
            line: 78
            column: 7
            file: file:///D:/a/citgm/citgm/test/test-temp-directory.js
            type: Test
          stack: |
            Test.<anonymous> (file:///test/test-temp-directory.js:78:7)
          ...
        
        # failed 1 test
    not ok 4 - tempDirectory.remove: bad path # time=16.777ms
    
    1..4
    # failed 1 of 4 tests
    # time=57.393ms
not ok 21 - test/test-temp-directory.js # time=57.393ms

targos avatar Jul 31 '23 13:07 targos