lookup: unskip zeromq
I'm opening this to try it on our CI but I'm not sure it will work, because zeromq depends on CMake: https://github.com/zeromq/zeromq.js#building-from-source
Actions CI: https://github.com/targos/citgm/actions/runs/627134439 Node CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/138/
Codecov Report
Merging #850 (dc3349e) into main (d0185d9) will decrease coverage by
0.21%. The diff coverage isn/a.
@@ Coverage Diff @@
## main #850 +/- ##
==========================================
- Coverage 96.12% 95.90% -0.22%
==========================================
Files 31 31
Lines 929 929
==========================================
- Hits 893 891 -2
- Misses 36 38 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/match-conditions.js | 89.36% <0.00%> (-4.26%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d0185d9...dc3349e. Read the comment docs.
FWIW we do have cmake on a lot of platforms in the CI now. It’s used in the libuv builds.
It fails everywhere, and not only because of missing cmake... I'll keep this open in case someone wants to look into it.
Hey all, I made a boo boo on main and had to force push. I've rebased this branch and force pushed to make sure that you don't have to do extra work because of my mistake