citgm icon indicating copy to clipboard operation
citgm copied to clipboard

lookup: unskip zeromq

Open targos opened this issue 5 years ago • 5 comments

I'm opening this to try it on our CI but I'm not sure it will work, because zeromq depends on CMake: https://github.com/zeromq/zeromq.js#building-from-source

targos avatar Mar 06 '21 11:03 targos

Actions CI: https://github.com/targos/citgm/actions/runs/627134439 Node CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/138/

targos avatar Mar 06 '21 11:03 targos

Codecov Report

Merging #850 (dc3349e) into main (d0185d9) will decrease coverage by 0.21%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
- Coverage   96.12%   95.90%   -0.22%     
==========================================
  Files          31       31              
  Lines         929      929              
==========================================
- Hits          893      891       -2     
- Misses         36       38       +2     
Impacted Files Coverage Δ
lib/match-conditions.js 89.36% <0.00%> (-4.26%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0185d9...dc3349e. Read the comment docs.

codecov-io avatar Mar 06 '21 11:03 codecov-io

FWIW we do have cmake on a lot of platforms in the CI now. It’s used in the libuv builds.

richardlau avatar Mar 06 '21 14:03 richardlau

It fails everywhere, and not only because of missing cmake... I'll keep this open in case someone wants to look into it.

targos avatar Mar 07 '21 09:03 targos

Hey all, I made a boo boo on main and had to force push. I've rebased this branch and force pushed to make sure that you don't have to do extra work because of my mistake

MylesBorins avatar Mar 18 '21 21:03 MylesBorins