citgm
citgm copied to clipboard
new zeromq version requires cmake
https://ci.nodejs.org/job/citgm-smoker/2082/nodes=ubuntu1804-64/testReport/junit/(root)/citgm/zeromq_v6_0_0_beta_2/
I don't know if it's something that we can reasonably install on all CI hosts. Until then, we should probably skip the module.
There's a movement among some napi users to start using cmake, too, so this might be more common.
I'm OK with cmake getting installed, though someone has to do it :-).
I'm OK with cmake getting installed, though someone has to do it :-).
/ping @nodejs/build
I believe there is now a strategic initiative underway to move Node.js to cmake. Getting cmake installed on the various CI machines would seem to be a good idea for that too. Fixing this would be a nice side-effect. @nodejs/build
I've been installing cmake onto the IBM platforms in the CI (libuv also uses cmake now) and tried to test zeromq without success.
zeromq's package.json
doesn't have a script called test
which CITGM is specifically looking for. https://github.com/nodejs/citgm/pull/811 will patch CITGM to allow it to continue if the package.json
doesn't have a test
script but we specify the scripts to run in our lookup.json
.
That still doesn't appear to be enough though. The cmake bits of the install process look to have succeeded but apparently no tests are found,
e.g. https://ci.nodejs.org/job/citgm-smoker-nobuild/875/ using the modified lookup.json
in https://github.com/richardlau/citgm/commit/c5af52cc8c1d2bc6885577fa6352458e200be9e7,
on centos7-ppcle:
https://ci.nodejs.org/job/citgm-smoker-nobuild/875/nodes=centos7-ppcle/consoleFull
...
12:50:47 error: | COPY Debug/zeromq.node
12:50:47 error: | make: Leaving directory '/home/iojs/tmp/citgm_tmp/885023f5-b4dc-4442-80fa-e4415ba3da4d/zeromq/build'
12:50:47 error: | Done in 29.41s.
12:50:47 error: | yarn run v1.22.4
12:50:47 error: | $ tsc --project tsconfig-build.json && mocha && script/format.sh && rm -f tmp/*
12:50:47 error: | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
12:50:47 error: |
12:50:47 error: | gmake[1]: warning: -jN forced in submake: disabling jobserver mode.
12:50:47 error: | gmake[1]: warning: -jN forced in submake: disabling jobserver mode.
12:50:47 error: error: | gmake[1]: warning: -jN forced in submake: disabling jobserver mode.
12:50:47 error: | [31mError: No test files found[39m
12:50:47 error: | error Command failed with exit code 1.
12:50:47 error: done | The smoke test has failed.