citgm icon indicating copy to clipboard operation
citgm copied to clipboard

Check if citgm is clean on Node master

Open targos opened this issue 6 years ago • 18 comments

CI run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1688/

I expect it to fail on Windows because of https://github.com/nodejs/citgm/issues/652 but if other platforms are red, we should look into the failures.

targos avatar Dec 15 '18 13:12 targos

iconv is handled in https://github.com/bnoordhuis/node-iconv/pull/194 and https://github.com/bnoordhuis/node-iconv/pull/189

targos avatar Dec 15 '18 14:12 targos

tape fails because it apparently does not support to run on a node-pre version:

 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/83f5bbf7-0f6d-46d9-b25b-0c18ea8722f9/tape/node_modules/parse-node-version/index.js:6
     throw new Error('Unable to parse: ' + version);
     ^
 Error: Unable to parse: v12.0.0-pre
     at parseNodeVersion (/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/83f5bbf7-0f6d-46d9-b25b-0c18ea8722f9/tape/node_modules/parse-node-version/index.js:6:11)
     at Object.<anonymous> (/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/83f5bbf7-0f6d-46d9-b25b-0c18ea8722f9/tape/node_modules/fancy-log/index.js:7:48)

targos avatar Dec 15 '18 14:12 targos

I added sqlite3, leveldown and level to the list in https://github.com/nodejs/node/issues/25060

targos avatar Dec 15 '18 14:12 targos

New run with version 5.0.2: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1848/

targos avatar May 14 '19 08:05 targos

5.0.3: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1852/

targos avatar May 18 '19 20:05 targos

New run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1881/

targos avatar Jun 18 '19 19:06 targos

New run with [email protected]: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2075/

targos avatar Oct 23 '19 12:10 targos

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2075/

failed hosts in CI package notes [edit freely]
8 citgm.csv-parser-v2.3.1 fix in master but not release /ping @shellscape
6 citgm.serialport-v7.1.5 serialport is expected to work with master when 8.x comes out of beta. Not sure what the expected release date is. /ping @reconbot
5 citgm.zeromq-v5.1.1 update is in progress. /ping @rolftimmermans
1 citgm.underscore-v1.9.1
1 citgm.torrent-stream-v1.2.0
1 citgm.socket.io-v2.3.0
1 citgm.radium-v0.26.0
1 citgm.ember-cli-v3.13.1
1 citgm.coffeescript-v2.4.1
1 citgm.acorn-v7.1.0

Trott avatar Oct 23 '19 16:10 Trott

I believe the csv-parser failures will go away once a new version of csv-parser is published. The fix for it is in master, but not in a release. /ping @shellscape

Trott avatar Oct 23 '19 16:10 Trott

My OSS backlog is massive right now. A house renovation and 8 month old teething transition to solid food crazy poop child is taking up most of my free time. I'm picking things off as I have the chance to. Gonna be a bit folks.

shellscape avatar Oct 23 '19 16:10 shellscape

serialport is expected to work with master when 8.x comes out of beta. Not sure what the expected release date is. /ping @reconbot

Trott avatar Oct 23 '19 16:10 Trott

For zeromq, from https://github.com/nodejs/node/pull/29504#issuecomment-534724551:

@rolftimmermans has a next generation version here that is on the roadmap to be merged back to master!

Trott avatar Oct 23 '19 16:10 Trott

FWIW here's another run against master (used to test some changes to the CI job): https://ci.nodejs.org/job/citgm-smoker/2078/

richardlau avatar Oct 25 '19 00:10 richardlau

@Trott got the release out today [email protected]

reconbot avatar Oct 27 '19 18:10 reconbot

Here's another one: https://ci.nodejs.org/job/citgm-smoker/2079/

failed hosts in CI package notes [edit freely]
10 citgm.csv-parser-v2.3.1 fix in master but not released yet
6 citgm.zeromq-v5.1.1 update is in progress
3 citgm.torrent-stream-v1.2.0
2 citgm.winston-v3.2.1
2 citgm.ember-cli-v3.13.1
1 citgm.spawn-wrap-v1.4.3
1 citgm.socket.io-v2.3.0
1 citgm.pug-v2.0.4
1 citgm.coffeescript-v2.4.1

Trott avatar Oct 28 '19 01:10 Trott

csv-parser has been updated

shellscape avatar Nov 07 '19 14:11 shellscape

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2085/

failed hosts in CI package notes [edit freely]
8 citgm.torrent-stream-v1.2.0 looks like this is partially or entirely a problem with mout? https://github.com/mout/mout/issues/261
6 citgm.zeromq-v6.0.0-beta.2 https://github.com/nodejs/citgm/issues/770
5 citgm.commander-v4.0.0
2 citgm.ember-cli-v3.13.1
1 citgm.winston-v3.2.1
1 citgm.socket.io-v2.3.0
1 citgm.pug-v2.0.4
1 citgm.coffeescript-v2.4.1

Trott avatar Nov 08 '19 01:11 Trott

mout v1.2.1 was released a few hours ago. It should fix some (or maybe even all) of our torrent-stream problems and possibly other issues.

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2086/

failed hosts in CI package notes [edit freely]
6 citgm.zeromq-v6.0.0-beta.3 #770
2 citgm.torrent-stream-v1.2.0
2 citgm.ember-cli-v3.13.1
2 citgm.commander-v4.0.0
1 citgm.winston-v3.2.1
1 citgm.multer-v1.4.2
1 citgm.coffeescript-v2.4.1

Trott avatar Nov 08 '19 18:11 Trott

Closing as stale and superseded by the most recent review in https://github.com/nodejs/citgm/issues/997

BethGriggs avatar Nov 22 '23 02:11 BethGriggs