citgm icon indicating copy to clipboard operation
citgm copied to clipboard

Missing collaborators

Open targos opened this issue 6 years ago • 17 comments

I feel like we don't have enough active contributors in citgm. PRs tend to get no review and stall. Is there something we can do to attract more people? This is a very important component of the release process.

/cc @nodejs/citgm

targos avatar Dec 11 '18 07:12 targos

Maybe we should start tagging some issues as good-first-contribution? Are there easy tasks that could be done?

What do you think @nodejs/community-committee?

mcollina avatar Dec 11 '18 08:12 mcollina

TBH I don’t think the issue is primarily first time contributions. There are not a ton of features that we need in CITGM (imho). That being said, we should empower current participants to review and land things. I feel as though I may be a bit of a blocker here, intentionally or not.

So I would like to state explicitly that I am 100% fine with anyone on the team landing anything they see fit at any cadence they see fit as long as it is in line with our contributor guidelines. Please do not block on my review even for larger changes to the overall architecture of the project. There is nothing that we can break in here that cannot be fixed with a bit of dedication and time.

Apologies if I am over estimating my influence here… I just wanted to ensure that I was not a blocker here.

On Dec 11, 2018, at 3:27 AM, Matteo Collina [email protected] wrote:

Maybe we should start tagging some issues as good-first-contribution? Are there easy tasks that could be done?

What do you think @nodejs/community-committee https://github.com/orgs/nodejs/teams/community-committee?

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/nodejs/citgm/issues/639#issuecomment-446113880, or mute the thread https://github.com/notifications/unsubscribe-auth/AAecVx24Jnj23atHDOXw95yyqOyL8frQks5u32x3gaJpZM4ZMysd.

MylesBorins avatar Dec 11 '18 15:12 MylesBorins

There were quite a few Windows PRs and that was the main blocker for me to review them. I guess that might apply to others as well.

BridgeAR avatar Dec 11 '18 15:12 BridgeAR

@BridgeAR to confirm, the blocker was that they were windows PRs?

MylesBorins avatar Dec 11 '18 15:12 MylesBorins

I was not especially thinking about Windows PRs. I should probably have written "collaborators" instead of "contributors". Just as an example, I opened 3 PRs 17 days ago to add popular modules to the lookup table. Nobody commented on them.

targos avatar Dec 11 '18 15:12 targos

@MylesBorins I don't have a Windows machine / VM and therefore I can't test anything on Windows and reviewing any PRs that are about Windows is therefore something I can't do.

BridgeAR avatar Dec 11 '18 15:12 BridgeAR

Related:https://github.com/nodejs/citgm/issues/440

targos avatar Dec 16 '18 14:12 targos

Sadly, this is still an issue :(

targos avatar Mar 07 '21 11:03 targos

/cc @nodejs/collaborators in case anyone is interested in becoming a member of the team 🙏🏻

targos avatar Mar 15 '21 15:03 targos

/cc @nodejs/collaborators in case anyone is interested in becoming a member of the team 🙏🏻

Sure, sign me up.

Trott avatar Mar 16 '21 02:03 Trott

I can help with reviewing as well.

mcollina avatar Mar 16 '21 08:03 mcollina

Is there a doc with any notes on how to contribute here?

dominykas avatar Mar 16 '21 08:03 dominykas

There's https://github.com/nodejs/citgm/blob/main/CONTRIBUTING.md

targos avatar Mar 16 '21 08:03 targos

I think I'm more curious if there's a prioritized list of issues or work that needs to be done? I suppose some of that is on a recurring basis?

I guess one can start with "good first issue", but in general - as an outsider - it's hard to know where to start, should one chose to become a longer term contributor.

dominykas avatar Mar 23 '21 11:03 dominykas

+1 that would be extremely useful, even if they're aspirational.

bnb avatar Mar 23 '21 15:03 bnb

+1, let me try this

himself65 avatar Mar 23 '21 15:03 himself65

To be clear: having more contributors would be awesome, but I'm really looking for "collaborators" (aka "maintainers"). People who can review and land pull requests.

targos avatar Mar 23 '21 15:03 targos