citgm icon indicating copy to clipboard operation
citgm copied to clipboard

add utp-native

Open mafintosh opened this issue 7 years ago • 9 comments

As discussed at the collab summit this adds utp-native, which is a precompiled native module that uses n-api and libuv.

Checklist
  • [x] npm test passes
  • [x] tests are included
  • [x] documentation is changed or added
  • [x] contribution guidelines followed here

mafintosh avatar Oct 13 '18 21:10 mafintosh

Please could you specify the hard and soft requirements the module fufills? https://github.com/nodejs/citgm/blob/master/CONTRIBUTING.md#submitting-a-module-to-citgm

richardlau avatar Dec 11 '18 16:12 richardlau

Ping @mafintosh

BridgeAR avatar May 14 '19 19:05 BridgeAR

Let's try it: https://github.com/targos/citgm/actions/runs/627140345

targos avatar Mar 06 '21 11:03 targos

Unfortunately, I think there's no way at the moment to make CITGM run something before npm install, and it seems necessary here to pull the git submodule.

targos avatar Mar 06 '21 11:03 targos

I got an idea. Rebased your branched and added:

    "install": ["install", "--ignore-scripts"],
    "scripts": ["fetch-libutp", "install", "test"]

CI: https://github.com/targos/citgm/actions/runs/627169509

targos avatar Mar 06 '21 11:03 targos

Of course, now it doesn't work because we don't clone the repository to test. We download the tarball from github.

targos avatar Mar 06 '21 11:03 targos

Codecov Report

Merging #610 (600ad8b) into main (d0185d9) will decrease coverage by 1.23%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
- Coverage   96.12%   94.88%   -1.24%     
==========================================
  Files          31       26       -5     
  Lines         929      900      -29     
==========================================
- Hits          893      854      -39     
- Misses         36       46      +10     
Impacted Files Coverage Δ
lib/spawn.js 69.23% <0.00%> (-30.77%) :arrow_down:
lib/match-conditions.js 82.97% <0.00%> (-10.64%) :arrow_down:
bin/citgm.js 98.00% <0.00%> (-2.00%) :arrow_down:
bin/citgm-all.js 91.00% <0.00%> (-1.00%) :arrow_down:
test/fixtures/omg-i-pass-with-scripts/build.js
test/fixtures/omg-i-write-to-tmpdir/test.js
test/fixtures/omg-i-timeout/test.js
...ixtures/omg-i-pass-with-install-param/test_args.js
test/fixtures/omg-i-pass-with-scripts/test.js

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0185d9...600ad8b. Read the comment docs.

codecov-io avatar Mar 06 '21 12:03 codecov-io

https://github.com/nodejs/citgm/actions/runs/629388332

targos avatar Mar 07 '21 11:03 targos

Hey all, I made a boo boo on main and had to force push. I've rebased this branch and force pushed to make sure that you don't have to do extra work because of my mistake

MylesBorins avatar Mar 18 '21 21:03 MylesBorins