citgm
citgm copied to clipboard
lookup: add astro
Checklist
- [x]
npm testpasses - [x] documentation is changed or added
- [x] contribution guidelines followed here
Ref: https://github.com/nodejs/citgm/issues/1054
Hard Requirements
- [x] Module source code must be on Github.
- [x] Published versions must include a tag on Github
- [ ] The test process must be executable with only the commands
npm install && npm testor (yarn install && yarn testorpnpm install && pnpm test) using the tarball downloaded from the Github tag mentioned above - don't think it's relevant anymore as you havescripts - [ ] The tests pass on supported major release lines - Tested locally but wanna test that also on our CI
- [x] The maintainers of the module remain responsive when there are problems
- [x] At least one module maintainer must be added to the lookup maintainers field
Soft Requirements
At least one of:
- [ ] The module must be actively used by the community OR
- [ ] The module must be heavily depended on OR
- [ ] The module must cover unique portions of our API OR
- [x] The module fits into a key category (e.g. Testing, Streams, Monitoring, etc.)
OR - Yes, this is the first big project that uses
node:test - [ ] The module is under the Node.js foundation Github org OR
- [ ] The module is identified as an important module by a Node.js Working Group
Run this branch on CITGM to make sure I'm not introducing flaky tests:
- https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/250/console
TODO
- [ ] update astro test:citgm command to run only the astro package tests as they take too long (more than 30m)
- [ ] Only build the package that testing
Before merging I wanna make sure it's not flaky and everything working correctly
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.35%. Comparing base (
12e6902) to head (01e904e).
Additional details and impacted files
@@ Coverage Diff @@
## main #1055 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 29 29
Lines 2192 2192
=======================================
Hits 2112 2112
Misses 80 80
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.