citgm icon indicating copy to clipboard operation
citgm copied to clipboard

lookup: add some AdonisJS dependencies

Open RomainLanz opened this issue 1 year ago • 10 comments

Hey there! 👋🏻

This PR adds some packages required by the AdonisJS Framework to the Gold Mine to ensure that any new Node.js version does not break our code or that we can provide a fix beforehand.

Checklist

Hard Requirements

  • [x] Module source code must be on Github.
  • [x] Published versions must include a tag on Github
  • [x] The test process must be executable with only the commands npm install && npm test or (yarn install && yarn test or pnpm install && pnpm test) using the tarball downloaded from the Github tag mentioned above
  • [x] The tests pass on supported major release lines
  • [x] The maintainers of the module remain responsive when there are problems
  • [x] At least one module maintainer must be added to the lookup maintainers field

Soft Requirements

At least one of:

  • [ ] The module must be actively used by the community
  • [ ] The module must be heavily depended on
  • [ ] The module must cover unique portions of our API
  • [x] The module fits into a key category (e.g. Testing, Streams, Monitoring, etc.)
  • [ ] The module is under the Node.js foundation Github org
  • [ ] The module is identified as an important module by a Node.js Working Group

--

  • [x] Contribution guidelines followed here

RomainLanz avatar Mar 07 '24 09:03 RomainLanz

@adonijs/core: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3416/ @adonijs/fold: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3417 @adonijs/http-server: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3418

if the above pass, we can land this PR. If not, you should fix the relative failures and/or limit the platforms that you are targeting.

mcollina avatar Apr 11 '24 17:04 mcollina

I have updated the lookup file to remove platforms we don't plan to work on.

It also seems that osx11-x64 and debian12-x64 reports timeouts for @adonisjs/core. I am not sure what to do about it.

RomainLanz avatar Apr 15 '24 11:04 RomainLanz

I think you can skip osx11-x64. I'm not sure about debian12-x64. There might be some race condition in those tests.

mcollina avatar Apr 15 '24 12:04 mcollina

Could you please re-run the @adonisjs/core test suite to see if it is a flaky test or if there are real issues on that platform?

RomainLanz avatar Apr 16 '24 08:04 RomainLanz

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3419/

mcollina avatar Apr 16 '24 15:04 mcollina

@RomainLanz There are a bunch of errors.

targos avatar May 08 '24 15:05 targos

I known. I haven't got time to see why we have tests timing out in some environments.

Also, I am not sure why the latest run didn't take the latest release that remove the "debug" mode.

RomainLanz avatar May 08 '24 15:05 RomainLanz

Here's a quick run on github actions with the latest release: https://github.com/nodejs/citgm/actions/runs/9004501814

targos avatar May 08 '24 15:05 targos

@RomainLanz You can run it locally with node bin/citgm.js @adonisjs/core

targos avatar May 08 '24 15:05 targos