citgm icon indicating copy to clipboard operation
citgm copied to clipboard

v21.x failing modules

Open RafaelGSS opened this issue 2 years ago • 10 comments

The last 3 runs failed on Node.js 21. I've run against v21.x just to confirm it's nothing related to the v21.3.0 proposal

  • v21.3.0 proposal (1) https://ci.nodejs.org/job/citgm-smoker/3350/
  • v21.3.0 proposal (2) https://ci.nodejs.org/job/citgm-smoker/3351/
  • v21.x https://ci.nodejs.org/job/citgm-smoker/3352/

Modules:

citgm.jest-v29.7.0 #1032 citgm.ember-cli-v5.4.1 - @stefanpenner, @rwjblue, @Turbo87, @kellyselden citgm.yeoman-generator-v7.1.1 - @SBoudrias, @sindresorhus citgm.nan-v2.18.0 - @nodejs/addon-api citgm.q-v1.5.1 - @kriskowal

RafaelGSS avatar Nov 30 '23 14:11 RafaelGSS

i believe maxogden → @max-mapper

ljharb avatar Nov 30 '23 15:11 ljharb

How can we check the logs? The @yarnpkg/cli logs seem unrelated to Yarn (ConnectTimeoutError: Connect Timeout Error), but perhaps I'm looking at the wrong place.

arcanis avatar Nov 30 '23 16:11 arcanis

@arcanis some of them might be related to the machine, yeah. I just want to make sure these timeouts aren't flaky on yarnpkg/cli but something with our machine

The ci.nodejs.org links are the ones with logs.

RafaelGSS avatar Nov 30 '23 16:11 RafaelGSS

AVA's failure is (most likely) a known issue, fixed in main but not yet released.

novemberborn avatar Nov 30 '23 19:11 novemberborn

I tried looking into what might be the problem in binary-split, but it seems to work fine with Node v21.3. The logs for the failure above also says ConnectTimeoutError: Connect Timeout Error, so perhaps it's just a flaky test and not something that needs fixing?

mourner avatar Dec 03 '23 18:12 mourner

Timeout errors are usually machine issues since we run tests in parallel and the CPU can get stale causing timeouts. If this persists we can reduce/remove the concurrency - but it might affect the time elapsed of CITGM, which is undesirable.

RafaelGSS avatar Dec 03 '23 20:12 RafaelGSS

The ws failure is the same and on the same platform for all runs. On macOS, that test also fails on GHA sometimes. I would prefer not to do it, but I think I can skip it on macOS.

lpinca avatar Dec 03 '23 21:12 lpinca

I've just removed for the issue description the modules where the authors/maintainers confirmed the issues aren't related to the package itself. Thank you!

I'll wait maintainers' input for the other ones.

RafaelGSS avatar Dec 04 '23 22:12 RafaelGSS

I've read all the lists again and removed the ones failing with timeout, which tends to be a machine issue and I've created a PR to skip the non-machine-related failing on Node.js 21. https://github.com/nodejs/citgm/pull/1035

RafaelGSS avatar Dec 12 '23 19:12 RafaelGSS

Closing in favour of https://github.com/nodejs/citgm/issues/1060

RafaelGSS avatar May 22 '24 18:05 RafaelGSS