admin icon indicating copy to clipboard operation
admin copied to clipboard

Proposal: Completely disable "Discussions" within nodejs/node

Open ovflowd opened this issue 1 year ago • 30 comments

It is no mystery that on the Node.js project, we use solely "issues" (within nodejs/node) to propose RFCs, new features, and general discussions surrounding the Node runtime.

Issues are also used for help requests, although people get redirected to nodejs/help for help with Node.js;

The nodejs/node repository has a discussions tab that is rarely used (very few threads are posted). It does feel like a duplication of nodejs/help and isn't being used for what it was intended to be used for.

Let's disable the Discussions tab altogether for "nodejs/node." That said, there are WGs or other projects within the Node.js org that pretty well use discussions, such as nodejs/collaborators, nodejs/nodejs.org, and others.

Although having a "Discussions" tab can be seen as a positive thing, it requires extra moderation; it is often just misused and, at the moment, doesn't bring anything to the table.

ovflowd avatar Sep 09 '24 11:09 ovflowd

cc @nodejs/tsc

ovflowd avatar Sep 09 '24 11:09 ovflowd

In https://github.com/nodejs/admin/issues/771, the proposal was to migrate nodejs/help to Discussions, though that has not happened.

aduh95 avatar Sep 09 '24 12:09 aduh95

Welp, I believe that said issue should be superseded with this. We can indeed migrate those discussions as issues on nodejs/help, for any open discussion if needed and then disable discussions.

ovflowd avatar Sep 09 '24 13:09 ovflowd

IMO, help repo is not the duplicate of discussions, nodejs slack channel is.

gireeshpunathil avatar Sep 09 '24 13:09 gireeshpunathil

IMO, help repo is not the duplicate of discussions, nodejs slack channel is.

Have you read my thread at all? 😅🥲 ... I explicitly said that current discussions tab are not used for discussions but help questions (or at least this is my perception of the current usage of it)

Having that said, I believe that both GitHub issues + slack are the places where discussions happen today.

ovflowd avatar Sep 09 '24 13:09 ovflowd

(I updated my prior comment adding some clarifications)

ovflowd avatar Sep 09 '24 13:09 ovflowd

so, if we want the discussions to be better discoverable within the org, discussions needs to be retained in lieu of the slack channel. or else it makes sense to shut it down.

I agree that currently the actual discussions get spread thin all over the place.

gireeshpunathil avatar Sep 09 '24 13:09 gireeshpunathil

I still don't think you get it or I may be missing your point.

Actual discussions right now happen either within issues on nodejs/node or on issues or discussions tab from other repositories for their respective WGs/teams. But never within nodejs/node discussions tab.

Hence since we have dedicated places for discussions, and the discussions tab for nodejs/node is not used, it does make sense (imo) to shut it down.

ovflowd avatar Sep 09 '24 13:09 ovflowd

only discussions pertinent to node/node are scoped under node/node discussions, right? so discussions happening in issues or discussions tab in other repos are fair?

either way, I agree with your proposal to shut down the discussions tab.

gireeshpunathil avatar Sep 09 '24 14:09 gireeshpunathil

Just remember that the discussions tab on nodejs/node is a redirect to the global discussions tab of the entire org.

targos avatar Sep 09 '24 14:09 targos

Just remember that the discussions tab on nodejs/node is a redirect to the global discussions tab of the entire org.

I don't think so. They are their own discussions tab, the only difference is they are marked as the default one.

That can be disabled too.

ovflowd avatar Sep 09 '24 14:09 ovflowd

I tried it before posting my comment. They point to the same page.

targos avatar Sep 09 '24 14:09 targos

Relevant discussion regarding nodejs/help vs "Discussions" https://github.com/nodejs/admin/issues/802#issuecomment-1599035742

Relevant discussion regarding org discussions vs repo discussions: https://github.com/nodejs/admin/issues/679#issuecomment-1460523085

aduh95 avatar Sep 09 '24 14:09 aduh95

I tried it before posting my comment. They point to the same page.

Yes, but global discussions is not a thing -- you can configure to one of your repositories to be the default "discussions" tab that shows up on your org.

https://docs.github.com/en/organizations/managing-organization-settings/enabling-or-disabling-github-discussions-for-an-organization#enabling-or-disabling-github-discussions-for-your-organization

ovflowd avatar Sep 09 '24 14:09 ovflowd

+1 to disabling discussions.

jasnell avatar Sep 09 '24 14:09 jasnell

+1 to disable, I never found particular value in them

marco-ippolito avatar Sep 09 '24 18:09 marco-ippolito

+1 to disable, I can't really follow any relevant discussions in them.

mcollina avatar Sep 11 '24 10:09 mcollina

+1 to disable discussions

BridgeAR avatar Sep 11 '24 13:09 BridgeAR

I believe we got consensus here? Should we proceed then?

ovflowd avatar Sep 24 '24 22:09 ovflowd

I think there is consensus and we can disable them

marco-ippolito avatar Nov 06 '24 16:11 marco-ippolito

Did someone disable the feature? cc @nodejs/tsc

ovflowd avatar Nov 23 '24 01:11 ovflowd

Discussions cannot be disabled because they are set as the source for the nodejs organization's public discussions.

targos avatar Nov 23 '24 08:11 targos

Discussions cannot be disabled because they are set as the source for the nodejs organization's public discussions.

They can still be disabled if the org-wide feature gets disabled

ovflowd avatar Dec 17 '24 11:12 ovflowd

@nodejs/tsc is someone going to do this?

ovflowd avatar Mar 14 '25 12:03 ovflowd

hmm, likely needs some other tweaking. Is there an alternative repo for us to direct the org discussions to?

Image

jasnell avatar Mar 14 '25 16:03 jasnell

I believe you need to update the org discussion settings and disable "org" discussions (repositories can still individually have their own discussions area) it's just that nodejs/node is marked as the home (default) discussion for Node org. But that's exactly what we want to get rid off :)

ovflowd avatar Mar 14 '25 16:03 ovflowd

Monday we are releasing the Discord server too, on an unrelated note 🙈

ovflowd avatar Mar 14 '25 16:03 ovflowd

Ok, before making that change, let me just double check with @nodejs/tsc to make sure nothing has changed that alters the consensus here. If I see nothing by end of day Monday I'll make the switch.

jasnell avatar Mar 14 '25 16:03 jasnell

So, can it be disabled now?

bjohansebas avatar Apr 12 '25 18:04 bjohansebas

It feels strange to have both issues and discussions enabled at the same time in help repository. Which one should a user use if they need help? We should simplify the way to ask for help, not make it confusing.

bjohansebas avatar Apr 20 '25 02:04 bjohansebas