admin icon indicating copy to clipboard operation
admin copied to clipboard

Create GitHub Account for Shared Vercel Account

Open ovflowd opened this issue 2 years ago • 11 comments

We are creating a shared Vercel Account for Node.js Infra (Website) on the realm of Node.js Build ([email protected])

The shared account is just a placeholder account, as Vercel doesn't allow Password Logins. The account credentials will be stored on the Shared Bucket on Node.js's 1Password Account.

The account requires no permissions, nor be invited to the Node.js Org, and it's only functionality for now is to be used to login on Vercel without requiring us everytime to look the [email protected] email.

cc @nodejs/tsc @nodejs/build-infra

ovflowd avatar Nov 14 '23 17:11 ovflowd

I'll create the account under [email protected] to not block the [email protected] email (I'll try at least)

ovflowd avatar Nov 14 '23 17:11 ovflowd

@ovflowd I assume you don't need to receive email at that build+vercel address ?

Related, were are all of the vercel credentials/and related stuff needed to access/manage stored. Are they all in the 1Password account?

mhdawson avatar Nov 14 '23 23:11 mhdawson

@ovflowd I assume you don't need to receive email at that build+vercel address ?

Hmm I thought that it would route that to [email protected]? At least when I add a + on my Google Mail accounts it routes to the same email?

Related, were are all of the vercel credentials/and related stuff needed to access/manage stored. Are they all in the 1Password account?

Not sure if I got it right, but the Vercel account is owned by OpenJS right now; The idea was to have a shared account for the Node.js project that has access there so Build WG and maybe Web folks can access there when needed.

Sadly Vercel Auth system is not password-based but OAuth based, so either you login with a confirmation code email or with an integration, such as GitHub, hence the idea of making a GitHub Account just for logging-in to Vercel

ovflowd avatar Nov 14 '23 23:11 ovflowd

We could also maybe, simply create another email alias for Vercel, like [email protected] but since that GitHub account would be used only to login on Vercel, I thought that using an existing alias would suffice. We dont even need to add that GitHub account to the Node.js org, for example.

ovflowd avatar Nov 14 '23 23:11 ovflowd

At least when I add a + on my Google Mail accounts it routes to the same email?

From what I remember, this is one of the many quirks that are specific to Google's implementation, and not demanded by any standard. (I might be wrong, I was looking this up years ago and email is a mess…)

tniessen avatar Nov 15 '23 00:11 tniessen

Yes, [email protected] and [email protected] and [email protected] and [email protected] etc all go to the same [email protected] account on any Google email system.

ljharb avatar Nov 15 '23 01:11 ljharb

Oh stupid me! I had no idea this was a gmail thingy only.

So should we make another alias for a Vercel GitHub Account... org? Open to suggestions!

ovflowd avatar Nov 15 '23 10:11 ovflowd

I'm down for making a new alias or using the existing [email protected] alias, but it depends on what the build team (cc @nodejs/build) thinks about using [email protected] or creating a new one

ovflowd avatar Nov 15 '23 11:11 ovflowd

I've made a PR here, https://github.com/nodejs/email/pull/233 I feel that a dedicated alias makes more sense

ovflowd avatar Nov 15 '23 11:11 ovflowd

@ovflowd landed that PR and deployed, the email alias should now be working

mhdawson avatar Nov 17 '23 18:11 mhdawson

I've created the GitHub Account and stored on Node.js's 1Password. I've also linked the Vercel account with that GitHub Account.

To Login to Node.js's Infrastructure on Vercel, please go to https://vercel.com, and click to sign-in with GitHub. If you have the 1Password Extension it will prompt automatically to use the GitHub Account to Login to Vercel

cc @richardlau @Trott (and @bmuenzenmeyer if you want to get access to Vercel, please request access to our 1Password account)

ovflowd avatar Nov 17 '23 19:11 ovflowd