admin icon indicating copy to clipboard operation
admin copied to clipboard

Benchmark scripts used by an active Jenkins job are archived

Open legendecas opened this issue 2 years ago • 6 comments

The benchmark job https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/ is using the script https://github.com/nodejs/benchmarking/blob/master/experimental/benchmarks/community-benchmark/run.sh to run the benchmarks.

The script is cloning the repo with the HTTP protocol http://github.com/nodejs/node.git (it's been redirected to use HTTPS protocol automatically). Probably worth updating the script to use HTTPS instead.

However, the repository https://github.com/nodejs/benchmarking has been archived and can not be updated. Should we move the benchmarking scripts to a dedicated repo since the benchmarking working group has been de-chartered?

legendecas avatar Jan 16 '23 11:01 legendecas

What about moving it to node/tools?

RafaelGSS avatar Jan 18 '23 02:01 RafaelGSS

What about moving it to node/tools?

This can be an option. Or we can put it in https://github.com/nodejs/build/tree/main/jenkins/scripts like other Jenkins scripts.

legendecas avatar Jan 18 '23 09:01 legendecas

I think the latter is a good choice, indeed.

cc: @nodejs/build

RafaelGSS avatar Jan 18 '23 13:01 RafaelGSS

There is a PR to remove that stuff from the build repo too https://github.com/nodejs/build/pull/3145

nschonni avatar Jan 18 '23 14:01 nschonni

See also https://github.com/nodejs/build/issues/3277.

We could always unarchive https://github.com/nodejs/benchmarking. Would @nodejs/performance be interested in owning it?

You could open a PR to move the script to https://github.com/nodejs/build/tree/main/jenkins/scripts, but then every change to that script is going to be bottlenecked on the Build WG.

richardlau avatar Apr 03 '23 22:04 richardlau

I think we should keep it under nodejs/build.

anonrig avatar Apr 03 '23 22:04 anonrig