admin
admin copied to clipboard
nodejs
Set up Netlify for Pull Request previews for nodejs.org repo
Or something else that has the same effect.
Currently one has to pull down the changes locally to see them in action which is far from optimal.
@Trott can we do this please? It will really help with PRs. I can help setting it up after you add it to the repo.
@Trott can we do this please? It will really help with PRs. I can help setting it up after you add it to the repo.
You can either open a separate issue in the nodejs/admin repo, or I can transfer this issue there.
@Trott yeah, please move it where appropriate. I thought it belonged to this repo.
To clarify, I don't mind whatever solution we go with, we just need this to make our lives easier :)
Couldn't agree more, would love to have previews rather than being forced to run locally and/or ask for screenshots.
SGTM
Something new since I made this issue. Netlify has changed their pricing. Not sure if it will affect us, just throwing it out there.
In theory, we should be OK, at least for starters.
I guess we need to setup a Netlify account for the org. Should it belong to the Build WG?
https://github.com/nodejs/nodejs.dev has some sort of Google Cloud Build staging thing going on. Could that potentially be used? I think @MylesBorins set it up.
@richardlau TBH the setup that we have on nodejs.dev is not neccessarily ideal for everyone and is a little bit more hands on then simply installing netlify.
What about https://github.com/nodejs/admin/issues/422#issuecomment-539369086 ?
I guess we need to setup a Netlify account for the org. Should it belong to the Build WG?
I guess we need to setup a Netlify account for the org. Should it belong to the Build WG?
I think it should be more general. since all our doc service may need it.
The Build WG currently manages all Node secrets, so yes, I would say it's the build wg.
I think sending a PR to https://github.com/nodejs-private/secrets to store the credentials would be enough, people who place their public keys in the corresponding folder there would just get the access (but then yes currently only build and a few others have read access to that repo in the first place)
@joyeecheung I would be happy to send that PR if needed, pending getting the details from the Website WG.
I just got previews setup on nodejs.dev using GitHub actions, the nodejs-infrastructure gcp account, and a free tier cloudflare cdn.
I could likely spin this up to do staging previews for .org rather painlessly if folks are interested. With that said it isn't a huge deal to use netlify
