abi-stable-node Stale issues in node-addon-api to discuss

~~https://github.com/nodejs/node-addon-api/issues/449~~

Dec 17 '20 17:12 mhdawson

~~https://github.com/nodejs/node-addon-api/issues/541~~

EDIT: Closed as the requested methods are in N-API and latest release of node-addon-api

Dec 17 '20 17:12 mhdawson

~~https://github.com/nodejs/node-addon-api/issues/439~~

EDIT: Commented with our current thought

Dec 17 '20 17:12 mhdawson

~~https://github.com/nodejs/node-addon-api/issues/413~~

Dec 18 '20 19:12 mhdawson

~~https://github.com/nodejs/node-addon-api/issues/301~~

Dec 18 '20 19:12 mhdawson

~~https://github.com/nodejs/node-addon-api/issues/258~~

Dec 18 '20 19:12 mhdawson

~~https://github.com/nodejs/node-addon-api/issues/830#issuecomment-780216120~~

Feb 17 '21 22:02 mhdawson

~~https://github.com/nodejs/node-addon-api/issues/229#issuecomment-780957257~~

Striking out for now because there does not seem to be a reasonable way forward without engine support.

Feb 19 '21 21:02 mhdawson

~~https://github.com/nodejs/node-addon-api/issues/912~~

Jun 04 '21 15:06 KevinEady

~~https://github.com/nodejs/node-addon-api/issues/965~~

Jul 14 '21 08:07 KevinEady

~~https://github.com/nodejs/node-addon-api/issues/805~~

Jul 23 '21 07:07 KevinEady

~~https://github.com/nodejs/node-addon-api/issues/855~~

Jul 30 '21 08:07 NickNaso

~~Would like us to review - https://github.com/nodejs/node-addon-api/pull/1026 in the meeting if possible. Not stale but would be good to progres.~~

Sep 09 '21 15:09 mhdawson

~~https://github.com/nodejs/node-addon-api/pull/930~~

Sep 13 '21 19:09 mhdawson

https://github.com/nodejs/node-addon-api/issues/1114#issuecomment-1076942174

waiting on addition of sample to examples repo.

Mar 24 '22 15:03 mhdawson

https://github.com/nodejs/node-addon-api/issues/1109

Waiting on documentation update.

Documentation landed,

@gabrielschulhof is working on test of Threadsafe function in ObjectWrap.

Good next step would be to add to examples in node-addon-examples, which could use that test starting point.

Today waiting on release of node-addon-api.

Release has been made, @gabrielschulhof can look and confirm he can move forward.

PR is here - https://github.com/nodejs/node-addon-examples/pull/284

Jul 01 '22 15:07 KevinEady

https://github.com/nodejs/node-addon-api/issues/1066

Jul 12 '22 06:07 NickNaso

https://github.com/nodejs/node-addon-api/issues/1119

~~blocked on feature bits/runtime semantics~~

Plan is to

Change default for flag that controls force_node_api_uncaught_exceptions_policy to true for future version of Node-api
Document that developers can add a listener for unhandled exceptions to suppress the termination of the process if needed.

@legendecas has submitted - https://github.com/nodejs/node-addon-api/pull/1345 to address this one. (This landed)

PR to make flag default for EXPERIMENTAL - https://github.com/nodejs/node/pull/49313 -> this has now landed.

@legendecas is there anything more on this one or can we mark this as complete.

Sep 12 '22 17:09 mhdawson

https://github.com/nodejs/node-addon-api/issues/1095

Sep 30 '22 15:09 KevinEady

https://github.com/nodejs/node-addon-api/issues/1140

~~blocked on feature bits/runtime semantics~~

Plan is to

For future Node-API version make creation of finalizers default to pure by default
Add additional API that developers can use to run JavaScript in pure finalizer

This will affect an addon as it opts into the future Node-API version which includes this change.

@vmoroz the implementation in https://github.com/nodejs/node/pull/42651

https://github.com/nodejs/node/pull/42651 - landed

Sep 30 '22 15:09 KevinEady

https://github.com/nodejs/abi-stable-node/issues/441 (maybe related to https://github.com/nodejs/node/issues/44111) ?

Oct 07 '22 15:10 KevinEady