abi-stable-node icon indicating copy to clipboard operation
abi-stable-node copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

Enabled debug testing for addons

Open mhdawson opened this issue 5 years ago • 5 comments
trafficstars

We should look at enabled testing of addons under debug in core.

mhdawson avatar May 14 '20 20:05 mhdawson

@mhdawson can we add a field to our top-level CI job that would cause it to append --debug to the npm test command line that runs our tests?

gabrielschulhof avatar Jun 29 '20 15:06 gabrielschulhof

@gabrielschulhof do you mean an option when you run the job which can add the --debug or not? That might work, although I think in many cases we'd want Node.js to be compiled in debug which will be a challenge since right now we use the existing nightly builds instead of building Node.js

mhdawson avatar Jul 02 '20 19:07 mhdawson

I think there is also this issue for adding debug testing in core. https://github.com/nodejs/build/issues/1854

mhdawson avatar Jul 06 '20 15:07 mhdawson

Next steps

  • [x] Enable addon testing in existing debug CI runs - nodejs/build#1854
  • [ ] Create debug test for node-addon-api in node-addon-testing for single platform (linux) and master of Node.js.
  • [ ] Consider if we should run on all LTS versions

mhdawson avatar Jul 06 '20 15:07 mhdawson