Release icon indicating copy to clipboard operation
Release copied to clipboard

Nominating @marco-ippolito to releasers

Open RafaelGSS opened this issue 1 year ago • 10 comments

Hey folks,

I would like to nominate Marco Ippolito (@marco-ippolito) to the releasers team. He's helping us with the automation of security release and recently he prepared 2 releases as part of the onboarding process (to the automation).

He's also participating in releasers meetings in the past month.

RafaelGSS avatar Mar 07 '24 13:03 RafaelGSS

+1

richardlau avatar Mar 07 '24 14:03 richardlau

Huge +1!

ShogunPanda avatar Mar 07 '24 14:03 ShogunPanda

Big +1 from me!

UlisesGascon avatar Mar 07 '24 15:03 UlisesGascon

+1

targos avatar Mar 07 '24 15:03 targos

+1 (although to be clear I'm not a releaser)

mhdawson avatar Mar 08 '24 17:03 mhdawson

+1

ruyadorno avatar Mar 21 '24 16:03 ruyadorno

There's no objections and this has been open for a sufficient amount of time, let's move on with the onboarding steps.

ruyadorno avatar Mar 21 '24 16:03 ruyadorno

Onboarding steps: https://github.com/nodejs/Release/blob/main/GOVERNANCE.md#adding-new-releasers

Translated into checklist:

  • [x] Be added to the GitHub releasers team in the Node.js org (grants ci-release access)
  • [x] Be added to the GitHub security-release team in the Node.js and nodejs-private orgs
  • [x] Have a single, high quality SSH key added to the "dist" user on the primary www server (see below for guidelines regarding SSH key quality)
  • [x] Add your GPG key to your GitHub account for verification. Github Guide.
    • [x] Check that the key is added in your profile: https://github.com/your-username.gpg
  • [x] Open a PR to add their GPG key to the nodejs/node README.md https://github.com/nodejs/node/pull/52257
    • [x] Once landed, the key should be cherry-picked to all active release staging branches (i.e. the active vMM.x-staging branches).
    • Any future updates to the key should also be cherry-picked to all active release staging branches.
  • [x] Open a PR in nodejs/docker-node to add their GPG key to node.keys. https://github.com/nodejs/docker-node/pull/2055
  • [x] Open a PR in nodejs/release-keys to add their GPG key via ./cli.sh add $KEY_ID. https://github.com/nodejs/release-keys/pull/27
  • [x] Open a PR in nodejs/Release to add themselves under the "Releasers team" heading via ncu-team sync README.md. https://github.com/nodejs/Release/pull/996
  • [x] Add them to the #nodejs-release-private team on the OpenJS Slack.

I'll reopen this until we've checked off everything in the list.

richardlau avatar Mar 21 '24 16:03 richardlau

I'm proceeding with Marco's nomination.

RafaelGSS avatar Mar 28 '24 16:03 RafaelGSS

My SSH key:

ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIGtw5h6D+rUqAJn73pYn3QSJ7f7xI8kISB4Q2yNjUMoh [email protected]

marco-ippolito avatar Mar 28 '24 18:03 marco-ippolito

I guess we can close it now

marco-ippolito avatar Apr 29 '24 08:04 marco-ippolito