Release icon indicating copy to clipboard operation
Release copied to clipboard

problems with llhttp 9.x upgrades in v20.x

Open UlisesGascon opened this issue 1 year ago • 7 comments

I created this issue for visibility, based on team slack discussion

When I was working on the release 20.11.0 proposal (step 10) I was checking the dependencies and I got an error with the llhttp version.

I got the version 8.1.3, but the expected is 9.1.3 based on https://github.com/nodejs/node/pull/50080 as was included in the proposal.

The thing is that version 8.1.3 does not exist at all, as the current version is 8.1.0 since [email protected]. So, the issue is that LLHTTP_VERSION_MAJOR didn't got updated when cherry picking this commit, only the LLHTTP_VERSION_PATCH.

I added the label dont-land-on-v20 for now. But this error will occur again when landing new deps upgrades for llhttp in [email protected]. So maybe we can work on a backport for the next release

20.11.0 Proposal dependencies

Screenshot 2024-01-08 at 19 25 56

20.0.0 dependencies

Screenshot 2024-01-08 at 19 26 12

UlisesGascon avatar Jan 09 '24 10:01 UlisesGascon