Release icon indicating copy to clipboard operation
Release copied to clipboard

Add codename `Hydrogen` for node 18 to `README.md` and `schedule.json` file

Open HonkingGoose opened this issue 2 years ago • 1 comments

The CODENAMES.md file says that version 18.x has the Codename Hydrogen: https://github.com/nodejs/Release/blob/0f3230611ebcae7488e55ad1fffdf989a787a983/CODENAMES.md?plain=1#L11

But these files don't list the Hydrogen codename for to the 18.x release:

https://github.com/nodejs/Release/blob/0f3230611ebcae7488e55ad1fffdf989a787a983/README.md?plain=1#L9

https://github.com/nodejs/Release/blob/0f3230611ebcae7488e55ad1fffdf989a787a983/schedule.json#L98-L104

HonkingGoose avatar Aug 11 '22 09:08 HonkingGoose

Oh, I see Node 18.x is not yet released as stable LTS. Is that's why it doesn't have a codename in all the files?

HonkingGoose avatar Aug 11 '22 09:08 HonkingGoose

Oh, I see Node 18.x is not yet released as stable LTS. Is that's why it doesn't have a codename in all the files?

Correct. The codename only applies once the release has become LTS.

richardlau avatar Oct 20 '22 10:10 richardlau

Fixed by commit: https://github.com/nodejs/Release/commit/7277c242ca98cf3eb12b4e0c479ec5a5834f02a0

HonkingGoose avatar Oct 31 '22 10:10 HonkingGoose