crafthead icon indicating copy to clipboard operation
crafthead copied to clipboard

Allow fetching by texture IDs

Open violet-sh opened this issue 3 years ago • 5 comments

Closes #25. This allows you to fetch any resource by its texture ID.

There are two main things to consider with this pr:

  1. Using solely texture IDs, there is no way of knowing whether the skin is of the "slim" model variety or not. This is for the most part a non-issue, however, it causes problems with body rendering. It also means that any request by texture ID will return anX-Crafthead-Skin-Model header of default.
  2. There is also no way of knowing whether the texture is for a skin or cape. Currently, the pr just yolo's it, and requesting a cape just renders the texture as a cape even if it is a skin, and vice versa. This can cause very cursed images, but I guess if someone's requesting texture IDs directly they've probably done the due diligence of knowing what they need.

violet-sh avatar Feb 14 '22 18:02 violet-sh

Given people have to know what texture ID to fetch anyway, it's not unreasonable to expect them to know whether or not a skin needs to have a slim model. If we can assume that, it might be helpful to provide a way to request a slim model, perhaps with a query parameter such as ?slim or ?model=slim.

violet-sh avatar Feb 18 '22 15:02 violet-sh

This would be handy and opens up support for custom skins that are cached in the texture.minecraft.net/

FN-FAL113 avatar May 23 '22 14:05 FN-FAL113

bump

FN-FAL113 avatar Jun 24 '22 07:06 FN-FAL113

Hello. What are the status on this PR?

Hazmi35 avatar Dec 25 '23 11:12 Hazmi35

Apologies for the delay in getting back to this. We've done a lot of maintenance on this repo since this PR was opened. Is this something folks are still wanting/needing?

Cherry avatar Mar 03 '24 19:03 Cherry