node-solid-server icon indicating copy to clipboard operation
node-solid-server copied to clipboard

Failing tests in `solid-contrib/solid-crud-tests`

Open mrvahedi68 opened this issue 2 years ago • 4 comments

During the testing process on https://solid-crud-tests-example-1.solidcommunity.net, several tests have unfortunately not yielded successful results.

The tests in question specifically pertain to the Notification and Storage categories. To provide a concise overview:

FAIL  test/surface/notifications.test.ts
Notifications
When overwriting plain text with plain text using PUT
  ✕ WPS  insecure websockets-pubsub advertised using Updates-Via Link header (11 ms)
  ✓ WPS  emits insecure websockets-pubsub on the resource (1 ms)
  ✕ SECURE_WEBSOCKETS  secure websockets advertised using server-wide or resource-specific Link header (3 ms)
  ✓ SECURE_WEBSOCKETS  emits secure websockets notification on the resource
  ✕ WEBHOOKS  webhooks advertised using server-wide or resource-specific Link header (1 ms)
  ✕ WEBHOOKS  emits webhook notification on the resource (1 ms)
 

FAIL  test/surface/fetch-pod-root.test.ts
Alice's storage root
  ✕ is an ldp BasicContainer (3 ms)

mrvahedi68 avatar Aug 22 '23 06:08 mrvahedi68

but the tests pass in https://github.com/nodeSolidServer/node-solid-server/actions/runs/4629453705/workflow#L48 right?

michielbdejong avatar Aug 24 '23 13:08 michielbdejong

By setting ALICE_WEBID=https://solid-crud-tests-example-1.solidcommunity.net/profile/card#me One of them passed:

PASS  test/surface/fetch-pod-root.test.ts
Alice's storage root
 ✓ is an ldp BasicContainer (1222 ms)

mrvahedi68 avatar Aug 24 '23 19:08 mrvahedi68

Ah god, Problem was with the main branch !!! I must use nss-skips branch and here is the results:

Screen Shot 1402-06-02 at 23 32 34

The requested changes in this PR is required for this branch also.

mrvahedi68 avatar Aug 24 '23 20:08 mrvahedi68

OK, https://github.com/solid-contrib/solid-crud-tests/pull/67 merged - can you create the equivalent PR against the nss-skips branch? And then I think we can close this issue.

michielbdejong avatar Aug 25 '23 07:08 michielbdejong