node-solid-server icon indicating copy to clipboard operation
node-solid-server copied to clipboard

Payment pointer Bob fails

Open bourgeoa opened this issue 2 years ago • 10 comments

@michielbdejong I skipped the corresponding test :

 1) API
       Payment Pointer Bob
         GET Payment Pointer document
           should redirect to example.com:
     Error: write EPROTO 139799603906496:error:1408F10B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:332:

      at WriteWrap.onWriteComplete [as oncomplete] (node:internal/stream_base_commons:94:16)

bourgeoa avatar Feb 04 '23 10:02 bourgeoa

Thanks for the heads-up.

Ah, this started failing because the cert on https://bob.com/ expired! Should be easy to fix by changing "bob.com" to "example.com", or some other domain name.

michielbdejong avatar Feb 06 '23 09:02 michielbdejong

replacing bob.com with example.com or service.com did not resolve the issue. https://github.com/nodeSolidServer/node-solid-server/blob/0bb5e9924b11656a9e4a51e5035d988455b04576/test/integration/payment-pointer-test.js#L108

certificates do not appear to be old -rwxrwxrwx 1 root root 1285 Feb 17 16:59 cert.pem

Error: write EPROTO 140539925039040:error:1408F10B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:332:

bourgeoa avatar Mar 12 '23 17:03 bourgeoa

Possibly related: https://superuser.com/questions/1754642/ssl-error-wrong-version-number

zg009 avatar Mar 27 '24 15:03 zg009

@bourgeoa This test is passing for me on main branch when I removed the skip. I have self-signed certificates that I created less than a month ago. That could be your issue?

zg009 avatar Apr 06 '24 04:04 zg009

@zg009 No explanation. My keys are young and the test is still failing

# ls -al test/keys
total 32
drwxrwxrwx 1 root root  512 Mar 10 10:54 .
drwxrwxrwx 1 root root  512 Mar 23 14:55 ..
-rwxrwxrwx 1 root root 1285 Mar 10 10:54 cert.pem
-rwxrwxrwx 1 root root 1107 Mar 10 10:54 client-cert.pem
-rwxrwxrwx 1 root root 1679 Mar 10 10:54 client-key.pem
-rwxrwxrwx 1 root root 1679 Mar 10 10:54 key.pem
-rwxrwxrwx 1 root root 1386 Mar 10 10:54 user1-cert.pem
-rwxrwxrwx 1 root root 1703 Mar 10 10:54 user1-key.pem
-rwxrwxrwx 1 root root 1314 Mar 10 10:54 user2-cert.pem
-rwxrwxrwx 1 root root 1675 Mar 10 10:54 user2-key.pem

bourgeoa avatar Apr 07 '24 17:04 bourgeoa

@bourgeoa I am running NSS tests on WSL v2 in Ubuntu 20.04. My version of OpenSSL is 1.1.1f. It may be a versioning/OS issue.

zg009 avatar Apr 07 '24 20:04 zg009

@zg009 You are right the test passes with WSL2 in ubuntu 20.04, but fails on WSL 1 that I am normally using On the contrary with WSL2 an other test fails in http-test.js (POST multipart) but succeed in WSL1

Strange

bourgeoa avatar Apr 09 '24 15:04 bourgeoa

@zg009 You are right the test passes with WSL2 in ubuntu 20.04, but fails on WSL 1 that I am normally using On the contrary with WSL2 an other test fails in http-test.js (POST multipart) but succeed in WSL1

Strange

@bourgeoa Can you point out the line it http-test POST which fails? All of mine are passing on WSL2.

zg009 avatar Apr 09 '24 16:04 zg009

This is the test that fails for me on WSL2 https://github.com/nodeSolidServer/node-solid-server/blob/21096e209d7c6e23f67c8b4bf9ad546301ebf4a3/test/integration/http-test.js#L1161

bourgeoa avatar Apr 09 '24 17:04 bourgeoa

This is the test that fails for me on WSL2

https://github.com/nodeSolidServer/node-solid-server/blob/21096e209d7c6e23f67c8b4bf9ad546301ebf4a3/test/integration/http-test.js#L1161

This is working for me on WSL2 on the main branch. I'm not sure what the issue could be just scanning the file. Can you rerun it and show the full error? I'm wondering where it is failing the test.

zg009 avatar Apr 09 '24 21:04 zg009