node-red-web-nodes icon indicating copy to clipboard operation
node-red-web-nodes copied to clipboard

Published 20 hours ago • verified publisher icon node-red

Barclays Cycle Hire Node

Open Raminios opened this issue 10 years ago • 5 comments

Added the barclays cycle hire node. The query node is the intended implementation, the input node is temporary and a full implementation should come after feedback. Feedback/comments welcome!

Raminios avatar Nov 21 '14 19:11 Raminios

Coverage Status

Coverage remained the same when pulling 03d19e602f55a220a0649f9388f2a5ed7ef4cb31 on Raminios:london-cycle-node into 19b1e01367d10ac5b24eaee3ab43e50757d9495f on node-red:master.

coveralls avatar Nov 21 '14 19:11 coveralls

You'll need to move your nodes into the ./transport directory. See @hbeeken 's work on the underground node and ensure that you follow her conventions. I did the same for my buses node. Whoever gets in first is to be followed by the rest and regard them as new, accepted conventions. ;)

zobalogh avatar Nov 28 '14 15:11 zobalogh

@Raminios , you'll still need to move the node into the ./transport directory. Also, name it "tfl-cyclehire" or similar. Thanks!

zobalogh avatar Dec 08 '14 10:12 zobalogh

@zobalogh Both of these changes have been made? If i click the files changed tab I see all files under transport and using the node name tfl-cyclehire. Is it still necessary for the file names to be tfl-cyclehire? I thought them being in that directory would suffice

Raminios avatar Dec 08 '14 11:12 Raminios

@Raminios OK, I looked at my local copy of your repository, sorry. It must be out of date for some reason. I think calling it tfl-cyclehire is better as that name will be included in flows. However this is not "THE" cycle hire node, it's TfL specific.

zobalogh avatar Dec 08 '14 11:12 zobalogh