node-red-web-nodes icon indicating copy to clipboard operation
node-red-web-nodes copied to clipboard

added category translation to google directions/geocoding & openweathermap

Open heikokue opened this issue 3 years ago • 5 comments

  • [?] Bugfix (non-breaking change which fixes an issue)
  • [?] New feature (non-breaking change which adds functionality)

Proposed changes

  • added category translation to google directions/geocoding & openweathermap

Checklist

  • [x] I have read the contribution guidelines
  • [ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • [ ] I have run grunt to verify the unit tests pass
  • [ ] I have added suitable unit tests to cover the new/changed functionality

heikokue avatar Mar 29 '21 15:03 heikokue

Coverage Status

Coverage remained the same at 71.026% when pulling 779a4fbf62528d89c4542337a7f2682155d265c9 on heikokue:category_translation into e0c0dd362779b9620c255b78e8fc0bdb9d1a46ab on node-red:master.

coveralls avatar Mar 29 '21 15:03 coveralls

I know the fitbit api has been broken/changed for ages - not sure about the strava one.

We inherited the node-red-web-nodes from another group - and they are rarely maintained and not often used by ourselves. - So really not much point in updating them unless you have tested them.

dceejay avatar Mar 29 '21 20:03 dceejay

Strava is very broken. I put a ticket request in that it be looked at (it's beyond my skills). I'd love to see it work again. But yeah, no point in translating a broken node.

On Mon, Mar 29, 2021 at 1:25 PM Dave Conway-Jones @.***> wrote:

I know the fitbit api has been broken/changed for ages - not sure about the strava one. Not much point in updating them unless you have tested them.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/node-red/node-red-web-nodes/pull/278#issuecomment-809687730, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYLAHEYGXB2X6QKBATVSE3TGDV5DANCNFSM4Z7Y65YA .

thebaldgeek avatar Mar 29 '21 21:03 thebaldgeek

OK, I changed to only google directions/geocoding & openweathermap

heikokue avatar Mar 30 '21 18:03 heikokue

please wait with bump! the DE helps of google and openweathermap are still outstanding. both nodes have quite high download rates...

heikokue avatar Mar 30 '21 18:03 heikokue