node-red-web-nodes icon indicating copy to clipboard operation
node-red-web-nodes copied to clipboard

Published 20 hours ago • verified publisher icon node-red

A few improvements to calendar node

Open dsl400 opened this issue 4 years ago • 2 comments

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)

Proposed changes

node settings now allows selection of calendar by name instead of pasting in the id or name of the calendar added ability to get complete list of calendars and filter it

Checklist

  • [x] I have read the contribution guidelines
  • [ ] For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • [ ] I have run grunt to verify the unit tests pass
  • [ ] I have added suitable unit tests to cover the new/changed functionality

dsl400 avatar Oct 03 '20 20:10 dsl400

Hi @dsl400, apologies for not getting to this. Due to another previous PR this now has conflicts... any chance you can resolve them for us and check your PR still works as intended ? And please run grunt to check tests pass... Many thanks

dceejay avatar Oct 25 '20 22:10 dceejay

Very close - sadly we still like { } :-)

and we now seem to have nextStartingEvent defined twice...

dceejay avatar Nov 23 '20 21:11 dceejay