node-red-web-nodes icon indicating copy to clipboard operation
node-red-web-nodes copied to clipboard

Improvements on error handling in forecastio and instagram nodes

Open tedhuang opened this issue 8 years ago • 3 comments

Instagram:

  • Added scope "public_content" required for liked photos
  • Some checks for undefined

Forecastio:

  • Added trim to lat, lon and apikey strings
  • Error handling in JSON parse for when forecastio API returns bad request in html page

tedhuang avatar May 18 '16 21:05 tedhuang

Hi, thanks for raising this.

As described in our contribution guidelines, we need a signed contributor license agreement in place before we can merge a pull request.

Nick

knolleary avatar May 18 '16 21:05 knolleary

node-red-gitbot: please update CLA status check

knolleary avatar May 18 '16 21:05 knolleary

Hi, I'm trying to get the tests to run with "istanbul cover grunt" as in the travis test but a lot of them are failing on nodes that haven't been touched in the commits. Is there anything special that I need to configure run to get the tests going? Thanks.

tedhuang avatar Aug 18 '16 19:08 tedhuang